ci: migrate to reusable test workflow - #405
Conversation
|
This PR is stale. Add a nice message, can mention maintainers or maintainer team to draw attention |
|
Loïc Minier (@lool) I'll be picking this up soon |
d891d43 to
5248af4
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| test-debian: | ||
| needs: [prepare-env] | ||
| name: "Test nodistro" | ||
| uses: mwasilew/meta-qcom/.github/workflows/test-distro.yml@debian-support |
| needs: [prepare-env] | ||
| name: "Test nodistro" | ||
| uses: mwasilew/meta-qcom/.github/workflows/test-distro.yml@debian-support | ||
| secrets: inherit |
Christopher Obbard (obbardc)
changed the title
Christopher Obbard (obbardc)
left a comment
Christopher Obbard (obbardc)
left a comment
There was a problem hiding this comment.
Looks good so far, some small thoughts!
| # qrb2210-rb1 testing is disabled until it can be resurrected; see #424 | ||
| # glymur-crd can't boot the distro kernel, only qcom-next | ||
| # monaco-arduino-monza and monaco-evk only validated against the | ||
| # linux-next/qcom-next/arduino | ||
| # kernels so far, not the distro kernel; see | ||
| # https://github.com/qualcomm-linux/qcom-deb-images/issues/440 | ||
| boards_exclude: '["glymur-crd", "lemans-evk", "monaco-arduino-monza", "monaco-evk", "qcs615-ride", "qcs8300-ride", "qrb2210-rb1"]' | ||
| boards_include: 'qcs6490-rb3gen2-vision-kit' |
There was a problem hiding this comment.
Just wondering why the other boards are not yet tested?
| # every board but monaco-arduino-monza; see | ||
| # https://github.com/qualcomm-linux/qcom-deb-images/issues/537 | ||
| boards_exclude: '["monaco-arduino-monza"]' | ||
| boards_include: 'glymur-crd,lemans-evk,monaco-evk,qcs615-ride,qcs6490-rb3gen2-vision-kit,qcs8300-ride,qrb2210-rb1' |
There was a problem hiding this comment.
why not keep boards_exclude ?
There was a problem hiding this comment.
oh, i see you removed boards_exclude, see later comment about that.
| description: Distribution suite (e.g. trixie, forky) | ||
| type: string | ||
| default: trixie | ||
| boards_include: |
There was a problem hiding this comment.
OK, we now don't have boards_exclude and have to manually set the list of boards to enable tests on. Not sure how I feel about that :/
There was a problem hiding this comment.
Ideally there would be just one list, but since different builds use different kernels I assume there needs to be some list of boards to test for each build. The include/exclude was added when test job templates were kept in the qcom-deb-images repository. Now the templates are moved to lava-test-plans. exclude makes sense only if you have a list of "all boards" somewhere. I don't think such list exists at the moment so from my pov it's best to just keep "include" list - list of boards to be tested. It's easier to maintain IMHO as there is nothing "hidden". Tests are only run on the boards listed in the workflow.
| fetch-depth: 0 | ||
| persist-credentials: false | ||
| - name: Print trigger | ||
| - name: "Print ref" |
There was a problem hiding this comment.
| - name: "Print ref" | |
| - name: Print lava-test-plans ref |
or similar ?
There was a problem hiding this comment.
done
| # never overwritten, so scope them by suite + run attempt instead. | ||
| test_job_file_name_prefix: ${{ inputs.suite }}-${{ github.run_attempt }}- | ||
| test-debian: | ||
| needs: [prepare-env] |
There was a problem hiding this comment.
remove [] from the needs, not needed
| test_job_file_name_prefix: ${{ inputs.suite }}-${{ github.run_attempt }}- | ||
| test-debian: | ||
| needs: [prepare-env] | ||
| name: "Test nodistro" |
There was a problem hiding this comment.
remove "" from the name ?
c01a192 to
14d1e99
Compare
Replace current testing setup with reusable test-distro.yml workflow from meta-qcom. Signed-off-by: Milosz Wasilewski <milosz.wasilewski@oss.qualcomm.com>
14d1e99 to
f9a1954
Compare
4 participants
Replace current testing setup with reusable test-distro.yml workflow from meta-qcom.
See also qualcomm-linux/lava-test-plans#30