Skip to content

New pydantic model class called Message #4

Description

@ninabel

Should be used for all communications between Server, Admin and Players.
It should encapsulate any data going anywhere in the system between any party. It will be shared with all the parties so it should go to quiz-common.

Now we send sometimes string and sometimes a dict over the network (for example sending 'y' form admin to server: https://github.com/quiz-cli/quiz-admin/blob/main/src/quiz_admin/__main__.py#L40)

This logic of parsing data should be part of the Message class: https://github.com/quiz-cli/quiz-client/blob/main/src/quiz_client/__main__.py#L40-L48

This is also sending of some unstructured dict to the network: https://github.com/quiz-cli/quiz-client/blob/main/src/quiz_client/__main__.py#L33

This is also some parsing logic (parse JSON. No? Print the text): https://github.com/quiz-cli/quiz-admin/blob/main/src/quiz_admin/__main__.py#L48-L51

We have to unify it all and send only JSON dict to the websocket every time.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

enhancementNew feature or request

Type

No type

Projects

  • Status
    In Progress

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions