Handle 128-bit writes to GS privileged registers - #243
Open
GTTeancum wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handle SQ stores to GS privileged registers by forwarding the low 64-bit lane to the existing register handler and discarding the upper lane. Non-FIFO 128-bit hardware writes use this behavior in PCSX2 as well. Without it, games that update DISPFB through SQ silently lose framebuffer flips.\n\nAdds a PS2Memory regression covering the target register and adjacent-slot preservation.\n\nTested: MINITEST_FILTER='quadword stores update one GS privileged register slot' ps2x_tests.exe