fix(android): use the active locale to detect RTL direction#57635
Open
zoontek wants to merge 2 commits into
Open
fix(android): use the active locale to detect RTL direction#57635zoontek wants to merge 2 commits into
zoontek wants to merge 2 commits into
Conversation
|
@Abbondanzo has imported this pull request. If you are a Meta employee, you can view this in D113244807. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
On Android, RTL detection read the wrong locale.
isDevicePreferredLanguageRTLuseLocale.getAvailableLocales()[0], which returns an arbitrary entry from the unordered list of all runtime locales (so, all locales that the current Android version supports), not the user's current system / app language. So layout direction was resolved from whatever locale happened to be first in that list, unrelated to the device (or per-app) language.This fixes it to read the active locale from
context.resources.configuration.locales[0], the resolved preferred locale for the app.See the screenshots below:
Locale.getAvailableLocales()[0]returns all locales supported by Android, so the first one is alwaysaf, andisRTLis alwaysfalse:vs
context.resources.configuration.locales[0]for the same device language (I chosear-JOin app settings),isRTListrue:Changelog:
[ANDROID] [FIXED] - Detect RTL from the active locale instead of an arbitrary installed one
Test Plan:
Switch the device (or per-app) language to an RTL language (e.g. Arabic) and confirm the app lays out RTL.
Locale.getAvailableLocales()[0](before, arbitrary):context.resources.configuration.locales[0](after, active locale):