Bump StackExchange.Redis from 3.0.25 to 3.1.0 - #541
Conversation
--- updated-dependencies: - dependency-name: StackExchange.Redis dependency-version: 3.1.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 319193740d
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| <PackageVersion Include="NetTopologySuite" Version="2.6.0" /> | ||
| <PackageVersion Include="System.Text.Json" Version="10.0.10" /> | ||
| <PackageVersion Include="StackExchange.Redis" Version="3.0.25" /> | ||
| <PackageVersion Include="StackExchange.Redis" Version="3.1.0" /> |
There was a problem hiding this comment.
Keep the public StackExchange.Redis floor at 3.0.x
This central version is consumed by src/NRedisStack/NRedisStack.csproj, so packages built from the library now require StackExchange.Redis >= 3.1.0 instead of keeping the documented 3.0.x compatibility floor. The retry-category code explicitly avoids referencing the 3.1.0-only enum names so older 3.0.x consumers still work (src/NRedisStack/RedisStackCommands/CommandCategories.cs:11-13), and the tests already use VersionOverride="3.1.0" specifically to check those names while staying ahead of the library floor (tests/NRedisStack.Tests/NRedisStack.Tests.csproj:39-42). Consumers that remain on StackExchange.Redis 3.0.x therefore lose compatibility without a code need for the library itself to raise the floor.
Useful? React with 👍 / 👎.
| <PackageVersion Include="NetTopologySuite" Version="2.6.0" /> | ||
| <PackageVersion Include="System.Text.Json" Version="10.0.10" /> | ||
| <PackageVersion Include="StackExchange.Redis" Version="3.0.25" /> | ||
| <PackageVersion Include="StackExchange.Redis" Version="3.1.0" /> |
There was a problem hiding this comment.
Avoid casting retry-wrapped async databases to IDatabase
With StackExchange.Redis 3.1.0, callers can pass a retry-wrapped database from WithRetry() to NRedisStack's async command classes because it is an IDatabaseAsync, but that wrapper is async-only and does not implement IDatabase. Every async module call routes through Auxiliary.ExecuteAsync, which unconditionally casts ((IDatabase)db).SetInfoInPipeline() (src/NRedisStack/Auxiliary.cs:75-77), so new JsonCommandsAsync(db.WithRetry()).GetAsync(...) throws InvalidCastException before the command is sent and the new retry categorization is unusable for async NRedisStack commands.
Useful? React with 👍 / 👎.
Updated StackExchange.Redis from 3.0.25 to 3.1.0.
Release notes
Sourced from StackExchange.Redis's releases.
No release notes found for this version range.
Commits viewable in compare view.
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)Note
Low Risk
Single dependency version bump with no code changes; risk is mainly regression or behavior differences in the Redis client between 3.0.x and 3.1.0, which CI/tests should catch.
Overview
Bumps the central NuGet version for StackExchange.Redis in
Directory.Packages.propsfrom 3.0.25 to 3.1.0. There are no source or project-file changes beyond that version pin; consumers that reference this package version will resolve the newer client library on restore/build.Reviewed by Cursor Bugbot for commit 3191937. Bugbot is set up for automated code reviews on this repo. Configure here.