Skip to content

fix(react-virtualized): exclude examples from coverage - #302

Merged
riceharvest merged 1 commit into
mainfrom
fix/react-virtualized-coverage-excludes-20260603-030000
Jun 3, 2026
Merged

fix(react-virtualized): exclude examples from coverage#302
riceharvest merged 1 commit into
mainfrom
fix/react-virtualized-coverage-excludes-20260603-030000

Conversation

@riceharvest

Copy link
Copy Markdown
Owner

Summary

  • Excludes react-virtualized example, demo, SSR, e2e, setup, and vendor files from V8 coverage collection
  • Adds a regression check so coverage config stays focused on runtime sources
  • Removes the noisy Rollup parse warnings from react-virtualized coverage runs

Tests

  • corepack pnpm@9.6.0 --filter @opensourceframework/react-virtualized test
  • corepack pnpm@9.6.0 --filter @opensourceframework/react-virtualized test:coverage (PARSE_WARNING_COUNT=0)
  • corepack pnpm@9.6.0 --filter @opensourceframework/react-virtualized lint
  • corepack pnpm@9.6.0 --filter @opensourceframework/react-virtualized typecheck
  • git diff --check

@qodo-code-review

Copy link
Copy Markdown

Qodo reviews are paused for this user.

Troubleshooting steps vary by plan Learn more →

On a Teams plan?
Reviews resume once this user has a paid seat and their Git account is linked in Qodo.
Link Git account →

Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center?
These require an Enterprise plan - Contact us
Contact us →

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d81b96b44b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

'source-stripped/demo/**',
'source-stripped/jest-setup.jsx',
'source-stripped/TestUtils.jsx',
'source-stripped/vendor/**',

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep vendored runtime modules in coverage

When coverage is run, this pattern drops all source-stripped/vendor modules even though they are part of the shipped runtime path: AutoSizer.jsx and WindowScroller.jsx import vendor/detectElementResize, and Masonry/PositionCache.jsx imports vendor/intervalTree which imports binarySearchBounds. Since coverage.include is source-stripped/**, this exclusion hides real runtime code from the coverage result rather than just examples/tests, so coverage can pass while missing exercised package behavior.

Useful? React with 👍 / 👎.

@riceharvest
riceharvest merged commit 0ba79ea into main Jun 3, 2026
10 checks passed
@riceharvest
riceharvest deleted the fix/react-virtualized-coverage-excludes-20260603-030000 branch June 3, 2026 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant