fix(client): allow execution submission enum layout - #1971
Closed
NathanFlurry wants to merge 2 commits into
Closed
NathanFlurry wants to merge 2 commits into
NathanFlurry wants to merge 2 commits into
Conversation
NathanFlurry
commented
Sep 10, 2026
NathanFlurry
commented
Member
- Allow the private execution submission enum layout under Rust 1.98 clippy.
- Avoid boxing the synchronous completion result and its additional allocation.
Co · session: Fix agentos main CI (clippy 1.98 + browserbase types)
|
![the-company-company[bot]](https://avatars.githubusercontent.com/in/3874572?s=60&v=4){kind=small}
NathanFlurry
added a commit
that referenced
this pull request
Sep 17, 2026
Allow clippy::large_enum_variant on the private ExecutionSubmission enum so cargo clippy --all-targets -D warnings passes on current stable. Boxing the completed result would add an allocation on the synchronous completion path. Refs #1971
Member
Author
|
Superseded by #1979. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.