Healthcheck returns exit code 1 when passing all tests

[tziuhtli]

Prerequisites

• I have searched for duplicate or closed issues
• I can recreate the issue with all plugins disabled

Describe the issue

I'm running a test environment using docker. Just noticed the exit codes are returning incorrect values.

Recreate this by running

php /var/www/html/bin/healthcheck.sh ; echo $?

This is my output on a vanilla container, nothing is configured.

DB: OK
IMAP: OK (localhost:143)
SMTP: NOT OK (Failed to connect to localhost:587)
0

Setting up smtp and imap, you get the following.

DB: OK
IMAP: OK (REDACTED)
SMTP: OK (REDACTED)
1

Note the exit codes are backwards, it should exit 0 when everything is ok and 1 when there are errors.

[tziuhtli]

I think the fix is in this line

roundcubemail/program/include/rcmail_healthchecker.php

Line 79 in 4b54c2a

return (int) $status;

One may negate the output:

 return (int) !$status;

Or alternatively, one may want to

return $status ? 0 : 1;

I'm not sure if this variable $status is the exit code. But if it, is I would also make it an integer from the beginning. Also, I don't have a full picture if this is used anywhere else. But I'm happy to submit a PR with the small changes.