Make ruby_memcheck optional - #4198
Merged
Merged
Conversation
It consistently fails CI when nokogiri tries to install from source. But those steps don't actually need it and the nokogiri version with this fix is still quite a long while out.
Earlopain
force-pushed
the
optional-memcheck
branch
from
August 4, 2026 16:00
1957475 to
a676a7d
Compare
Earlopain
commented
Aug 4, 2026
| env: | ||
| BUNDLER_VERSION: '0' # https://github.com/ruby/ruby/pull/16909 | ||
| BUNDLE_WITH: 'memcheck' | ||
| BUNDLER_VERSION: '0' |
Collaborator
Author
There was a problem hiding this comment.
Seems that newer bundler need this regardless when running with ruby-head, so I just removed the comment.
Collaborator
|
So if I understand correctly this makes the memcheck task attempt to install with the memcheck group, and the regular gemfile no longer tries to install memcheck right? So the memcheck task itself is still required? |
Collaborator
Author
|
It's still required, yes. |
kddnewton
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It consistently fails CI when nokogiri tries to install from source. But those steps don't actually need it and the nokogiri version with this fix is still quite a long while out.
Also bumps bundler to remove a workaround.