Skip to content

Fix Comment#trailing for syntax invalid edgecase #4218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kddnewton merged 1 commit into from
Sep 3, 2026
+12 −0
Merged

Fix Comment#trailing for syntax invalid edgecase #4218

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lib/prism/parse_result.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -744,6 +744,8 @@ class InlineComment < Comment
#: () -> bool
def trailing?
!location.start_line_slice.strip.empty?
rescue ArgumentError # invalid bytes, never whitespace only
false
end

# Returns a string representation of this comment.
Expand Down
10 changes: 10 additions & 0 deletions test/prism/result/comments_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,16 @@ def foo
)
end

def test_comment_trailing
comment = Prism.parse_comments("x # trailing")[0]
assert_predicate(comment, :trailing?)
end

def test_comment_syntax_invalid_bytes_trailing
comment = Prism.parse_comments("\xFF\xFE# not trailing")[0]
refute_predicate(comment, :trailing?)
end

def test___END__
result = Prism.parse(<<~RUBY)
__END__
Expand Down
Loading