Declare Singleton::SingletonInstanceMethods - #3037
Open
infiton wants to merge 1 commit into
Open
Conversation
Ruby 3.4 and later expose this internal module, and mechanically generated signatures can reference it. Register the module name just as RBS already does for SingletonClassMethods.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Declare the internal
Singleton::SingletonInstanceMethodsmodule in thesingletonstdlib signatures.Ruby 3.4 and later expose this module as part of
Singleton's implementation. Reflection-based signature generators can therefore produce declarations such as:RBS currently treats this as an unknown mixin because only the related
Singleton::SingletonClassMethodsname is declared.The new declaration is intentionally empty. Its methods are already represented directly on
Singleton; registering the name prevents mechanically generated signatures from failing validation. This matches the existing treatment ofSingletonClassMethods, added in #978.Tests
The
singletonlibrary signatures also passrbs validate.