feat(rc-multipart): list and abort incomplete uploads#269
Closed
cxymds wants to merge 1 commit into
Closed
Conversation
cxymds
force-pushed
the
cxymds/issue-1366-multipart
branch
from
July 21, 2026 05:57
a29c77b to
efec262
Compare
cxymds
force-pushed
the
cxymds/issue-1366-multipart
branch
from
July 21, 2026 06:00
efec262 to
9ec7923
Compare
cxymds
force-pushed
the
cxymds/issue-1366-multipart
branch
from
July 21, 2026 06:01
9ec7923 to
8be3b56
Compare
cxymds
force-pushed
the
cxymds/issue-1362-output-v3
branch
from
July 21, 2026 06:51
a50ab58 to
10d3f0b
Compare
cxymds
force-pushed
the
cxymds/issue-1366-multipart
branch
from
July 21, 2026 07:23
8be3b56 to
658f58d
Compare
cxymds
force-pushed
the
cxymds/issue-1366-multipart
branch
from
July 21, 2026 08:30
658f58d to
266541d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related work
Background
RustFS 1.0.0-beta.10 exposes S3 multipart list and abort operations, but its
ListMultipartUploadsimplementation interpretsprefixas an exact object key. Bucket-wide, prefix, and recursive cleanup therefore cannot be implemented safely until rustfs/backlog#1384 is resolved.This PR delivers the safe exact-key subset now and returns a typed unsupported-feature result before alias or network resolution for the affected modes. It intentionally does not close rustfs/backlog#1366 because recursive acceptance remains blocked by the server issue.
Solution
rc-coreobject-store boundary.ObjectStoreimplementations by providing defaultUnsupportedFeaturebodies for the new trait methods.ListMultipartUploadsandAbortMultipartUploadinrc-s3, including metadata mapping, retries, idempotent exact404 NoSuchUploadhandling, and defensive pagination validation.rc ls alias/bucket/key --incompletefor one exact object key with deterministic human and output-v3 JSON results.rc rm alias/bucket/key --incompletefor exact-key abort, dry-run planning, bounded concurrency, retry, deterministic ordering, and complete per-upload success/failure retention.partialenvelopes; partial cleanup retains both successful and failed upload records.crates/cli/src/main.rsdelta relative to its base.RustFS beta.10 compatibility and safety
NoSuchUploadcode; generic 404s and message substrings are not treated as success.Compatibility and migration
BREAKING contract process: this PR updates protected command-reference documentation and extends the output-v3 schema introduced by #266. It does not modify
schemas/output_v1.jsonorschemas/output_v2.json, and it does not change their runtime contracts. Multipart commands added here explicitly emit v3 envelopes.The dependency chain is
main -> #272 -> #266 -> #269; the command-launcher fix remains isolated in #272 and the output-v3 foundation remains isolated in #266.Validation
Static restack checks:
16de49fa3049b3cb05161b00c66232e06af1178fmain.rslauncher hunkcrates/cli/src/main.rsdelta relative to the feat(rc-output): introduce output schema v3 #266 basegit diff --checkpassesFinal isolated gates in
/tmp/rc-target-1366-finalwithCARGO_INCREMENTAL=0andCARGO_BUILD_JOBS=1:cargo fmt --all --checkcargo clippy --workspace -- -D warningscargo test --workspacecargo test -p rustfs-cli --test multipart_incomplete(9 passed)cargo test -p rustfs-cli --test output_schema_v3(6 passed)INSTA_UPDATE=no cargo test -p rustfs-cli --features golden --test golden(5 passed)jq emptyfor all schemas and JSON fixturesBREAKINGmarkerAll local checks pass.
Final review resolution (2026-07-21)
NotImplementedresponse remainsUnsupportedFeatureeven when RustFS returns HTTP 404.404 NoSuchUploadabort idempotence ahead of generic classification.cargo fmt --all --check,cargo clippy --workspace --all-targets -- -D warnings,cargo test --workspace, multipart (9 passed), output-v3 (6 passed), and golden (5 passed) gates in/tmp/rc-target-1366-rereview; all pass.