feat(rc-versioning)!: add version-aware object operations#270
Closed
cxymds wants to merge 1 commit into
Closed
Conversation
cxymds
marked this pull request as ready for review
July 21, 2026 06:06
cxymds
force-pushed
the
cxymds/issue-1368-versioning
branch
from
July 21, 2026 08:16
b16f9d4 to
7986997
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues and stack
Background and user impact
Version selectors reached the S3 adapter, but version-aware JSON still used legacy command-specific shapes. Partial multi-version deletion discarded successful removals, JSON dry runs mixed human text with JSON, and status-only authorization responses could be misclassified. The version-specific ObjectStore additions also had no safe defaults for non-S3 implementors, while the end-to-end version suite was disabled on Windows.
Root cause
Solution
versioned_objectsrecords for exact-version stat, version-bearing copy results, and version-aware removal.dry_run,outcome,planned,removed,failed, and summary fields.UnsupportedFeaturefor unsupported version-specific behavior.BREAKING change and migration
BREAKING: JSON produced by
stat --version-id,rm --version-id,rm --versions, andcpwhen the server reports version identifiers now uses the schema v3versioned_objectsenvelope. Successful data moves underdata; partial and failed operations usestatus: error, retain operation data, and are written as one JSON document to stderr.Unversioned stat/rm/cp JSON remains in its legacy shape.
schemas/output_v1.jsonandschemas/output_v2.jsonare byte-for-byte unchanged. Consumers should dispatch onschema_version, read operation results underdata, and usedata.plannedinstead ofdata.removedfor dry runs. The command references and output migration guide document the exact field mapping.Validation
cargo fmt --all --checkcargo clippy --workspace -- -D warningscargo test --workspaceINSTA_UPDATE=no cargo test -p rustfs-cli --features golden --test golden --target-dir /tmp/rc-target-1368-fixcargo test -p rustfs-cli --test output_schema_v3