feat(rc-site-replication)!: expose persisted resync snapshots#291
Merged
cxymds merged 1 commit intoJul 22, 2026
Conversation
cxymds
changed the base branch from
cxymds/issue-1418-site-replication-edit
to
main
July 22, 2026 04:27
cxymds
changed the base branch from
main
to
cxymds/issue-1418-site-replication-edit
July 22, 2026 04:28
Member
Author
|
Implementation and validation are complete for the current stacked revision ( Validation:
The PR remains Draft and correctly targets |
cxymds
marked this pull request as ready for review
July 22, 2026 12:42
cxymds
merged commit Jul 22, 2026
8937a3d
into
cxymds/issue-1418-site-replication-edit
16 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes rustfs/backlog#1419
Parent: rustfs/backlog#1411
Roadmap: rustfs/backlog#1381, rustfs/backlog#1361
Depends on: #290 and rustfs/backlog#1418
Background
RustFS beta10 exposes
PUT /rustfs/admin/v3/site-replication/resync/op, but its status response is a persisted snapshot of the last start or cancel handler invocation rather than live worker state. Without a typed and bounded CLI workflow, users can overstate lifecycle progress or blindly retry a mutation whose side effects may already have happened.Solution
rc admin replicate resync start|status|cancelwith exact peer selection and pre-network--yesconfirmation for mutationsadmin_operationspersisted_last_operationand lifecycle asunknownBREAKING contract note
This PR updates the protected
docs/reference/rc/behavior contract and is intentionally marked BREAKING. The new commands are additive and use the existing output-v3admin_operationsschema, so no schema-version migration is required. Automation must treatresult.lifecycle_stateasunknownand must not interpret resync status snapshots as live progress.Validation
cargo fmt --all --checkcargo clippy --workspace --all-targets -- -D warningscargo test --workspace -- --test-threads=1— 1230 passed, 0 failed, 1 ignored