fix: decode help-verifier subprocess output as UTF-8 - #86
Merged
Conversation
ryanduguid
marked this pull request as ready for review
September 10, 2026 09:20
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewPowered by Qodo |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Decode both help-verifier subprocess captures as UTF-8 so the lambda assertion behaves consistently under the Windows locale.
Verification: all 218 tests and the six workbook/source/signature/index/AFE verification gates passed on Python 3.10, 3.12 and 3.13. The 3.13 suite also passed with UTF-8 mode enabled. Ruff 0.16.6, mypy 2.3.1 and
git diff --checkpassed.This changes two test captures. Workbook bytes, formula sources and cached results are unchanged. Linux CI and native Excel gates were not run locally. The existing global Git hooks were retained; the repository-local pre-commit hook was not installed.