Conversation
Dropped directories are now read recursively using the File and Directory Entries API. A new dialog lets the user choose whether to send each folder as a ZIP archive (preserving its structure, created with the already bundled zip.js) or to send the contained files individually. The transfer protocol and the receiving side are unchanged. Closes schlagmichdoch#290 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #290
This implements folder sending as specified in #290:
- Dropped directories (onto the page or onto a peer) are read recursively using the
File and Directory Entries API using the approach referenced in the issue, with the
two known pitfalls handled: all entries are gathered synchronously before the drop
handler yields (the
DataTransferItemListis emptied afterwards), andreadEntries()is called in a loop since it returns at most 100 entries per call.- A new dialog then lets the user choose whether to send each folder as a ZIP
archive (directory structure preserved) or to send the contained files
individually - the optional chooser suggested in the issue.
- Zipping reuses the already bundled zip.js in store mode (level 0) via a dedicated
ZipWriter, so it cannot interfere with the shared writer used by the receive-side"download as zip". Progress is shown on the peer icon (peer drop) or via a
persistent notification (share mode).
- The transfer protocol, the server and the receiving side are unchanged - fully
compatible with older clients and the Android app.