fix security advisories in dev dependencies - #57
Open
irahopkinson wants to merge 1 commit into
Open
Conversation
Resolve four npm audit advisory groups in one lockfile resolution, superseding dependabot PRs #55 and #56. - vite 7.3.2 -> 7.3.6 (GHSA-fx2h-pf6j-xcff, GHSA-v6wh-96g9-6wx3) - js-yaml 4.1.1 -> 4.3.0 (GHSA-h67p-54hq-rp68, GHSA-52cp-r559-cp3m) - postcss 8.5.8 -> 8.5.23 (GHSA-qx2v-qp2m-jg93, GHSA-6g55-p6wh-862q, GHSA-r28c-9q8g-f849) - esbuild 0.27.3 -> 0.28.1 (GHSA-g7r4-m6w7-qqqr) - brace-expansion 1.1.14 -> 5.0.8, hoisted (GHSA-jxxr-4gwj-5jf2, GHSA-3jxr-9vmj-r5cp, GHSA-mh99-v99m-4gvg) Dependabot targeted vite 8.0.16, a major bump that swaps the build backend from esbuild/rollup to rolldown. The advisory range is 7.0.0 - 7.3.3, so 7.3.6 clears it without the toolchain change. All of these are devDependencies, and the published package declares no runtime or peer dependencies, so consumers are unaffected. The built dist/ output is byte-identical to main. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #57 +/- ##
=======================================
Coverage 81.40% 81.40%
=======================================
Files 4 4
Lines 328 328
Branches 78 78
=======================================
Hits 267 267
Misses 39 39
Partials 22 22 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Combined replacement for the two open dependabot security PRs, #55 (vite) and #56 (js-yaml). One lockfile resolution instead of two, and it clears two advisory groups neither dependabot PR touches.
Why not just merge #55 and #56
Dependabot overshot on vite. The advisory range is
7.0.0 - 7.3.3and 7.3.6 is published, but #55 targets 8.0.16 — a major bump that swaps the build backend from esbuild/rollup to rolldown (and isn't evenlatest, which is 8.1.5).vite@7.3.6clears the advisory with no toolchain change.Both lockfiles fail idempotence. Baseline:
npm install --package-lock-onlyonmainwith npm 11.6.1 is a no-op. Both PRs diverge from it, in opposite directions:npm iafter merge reintroduces"peer": trueentries@emnapi/*optional entries and alllibcfields (8 ins / 53 del)Dependabot is resolving with a different npm than CI's node 24. CI passes on both because these fields don't affect installs, but the lock lands dirty.
What this PR changes
package.json:vite^7.3.2→^7.3.6. Everything else is transitive, vianpm audit fix.postcss and esbuild are new here — neither dependabot PR addresses them. Remaining lock changes are the 26
@esbuild/*platform binaries,nanoid3.3.11 → 3.3.16 (postcss transitive), andminimatch/balanced-matchhoisting. All 45 changed entries are security-driven; no unrelated bumps.Not user-facing
The published package declares no
dependencies, nopeerDependencies, noengines— consumers get zero transitive deps, so none of these reach them. All aredevDependencies;js-yamlis only reachable at lint time via@eslint/eslintrc→FlatCompat.Built
dist/index.es.js,dist/index.cjs.js, anddist/index.d.tsare all byte-identical tomain, so no version bump is needed.For contrast, vite 8 does rewrite the shipped bundle:
index.es.js20.7 kB → 13.0 kB, 809 → 386 lines. I checked it functionally — identical.d.ts, same 6 exports, and a 112-assertion runtime digest over both the ESM and CJS bundles matched except the minified class-name letter ofVerseRefException(D→N/f, already non-semantic). So vite 8 looks safe when we do want it, just not needed for this advisory.Verification
Full CI gate locally on node 24 / npm 11.6.1 —
npm run lint,npm run prettier:ci,npm run build,npm run test:ci(40/40 passing) — plus:dist/byte-identical tomainnpm audit: 4 advisory groups cleared, 1 residual (below)Known residual
brace-expansion@1.1.16via@eslint/eslintrc@3.3.5→minimatch@3.1.5, reported as 3 high (one chain). Deliberately left alone:npm audit fix --force"fixes" it by downgrading@eslint/eslintrcto 0.1.0overridespin ofminimatch@^10reports 0 vulnerabilities but breaks lint —minimatch@10has no default export andeslintrcimports it as defaultIt's a dev-only DoS whose input is our own eslint config globs. The real fix is migrating
eslint.config.mjsoffFlatCompatto native flat config, which would drop bothjs-yamland thisbrace-expansionfrom the tree entirely — worth its own PR.Follow-up
Leaving #55 and #56 open; they can be rebased once this merges. If dependabot auto-closes them, the fixes landed correctly.
🤖 Generated with Claude Code