Save no-capture-start based on type argument rather than name - #1097
Open
EatonEmmerich wants to merge 1 commit into
Open
EatonEmmerich wants to merge 1 commit into
EatonEmmerich wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing behavior of no_capture_start assumes that the stop-capture list still stops all the streams, but the existing tests assumes that when starting the tied-array-channelised-voltage streams, all the streams will be started automatically.
Updated the no-capture-start to only include the types of streams we want to test instead.
Checklist (if not applicable, edit to add
(N/A)and mark as done):(N/A)If dependencies are added/removed: updatepyproject.tomland.pre-commit-config.yaml.(N/A)If new source files are added: add copyright notices dated with the current year.(N/A)If qualification tests are changed: attach or link to a sample qualification report.(N/A)If design has changed: ensure documentation is up to date.(N/A)If ICD-defined sensors have been added: updatefake_servers.pyin katsdpcontroller to match.(N/A)If the interface between the product controller and an engine has changed, update theVERSION constant for the engine (update the major number if sensors/requests have been
removed/changed, minor number if only backwards-compatible changes have been done).
Also, update doc/control.rst with the new version.
Closes NGC-2134.