Skip to content

fix(sources): validate GitHub repository hosts #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
harlan-zw merged 1 commit into from
Aug 14, 2026
+19 −4
Merged

fix(sources): validate GitHub repository hosts #94

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions src/core/url.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import { GIT_PLUS_PREFIX_RE, GIT_PROTOCOL_PREFIX_RE, GIT_SUFFIX_RE, GITHUB_SSH_URL_PREFIX_RE } from './regex.ts'

const STATIC_REGEX_1 = /github\.com\/([^/]+)\/([^/]+?)(?:\.git)?(?:[/#]|$)/
const STATIC_REGEX_3 = /#.*$/
const STATIC_REGEX_7 = /^git@github\.com:/
const STATIC_REGEX_8 = /^(?:127\.|10\.|172\.(?:1[6-9]|2\d|3[01])\.|192\.168\.|169\.254\.)/
Expand All @@ -17,10 +16,19 @@ const STATIC_REGEX_9 = /^\[(?:f[cd]|fe[89ab]|::ffff:)/i
* Parse owner/repo from GitHub URL
*/
export function parseGitHubUrl(url: string): { owner: string, repo: string } | null {
const match = url.match(STATIC_REGEX_1)
if (!match)
try {
const parsed = new URL(url)
if (parsed.hostname !== 'github.com' && parsed.hostname !== 'www.github.com')
return null
const [, owner, repoWithSuffix] = parsed.pathname.split('/')
const repo = repoWithSuffix?.replace(GIT_SUFFIX_RE, '')
if (!owner || !repo)
return null
return { owner, repo }
}
catch {
return null
return { owner: match[1]!, repo: match[2]! }
}
}

/** Parse owner/repo slug from GitHub URL */
Expand Down
7 changes: 7 additions & 0 deletions test/unit/sources-utils.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,10 @@ describe('sources/utils', () => {
owner: 'owner',
repo: 'repo',
})
expect(parseGitHubUrl('https://github.com/owner/repo.git/tree/main')).toEqual({
owner: 'owner',
repo: 'repo',
})
})

it('strips .git suffix from repo name', () => {
Expand All @@ -52,6 +56,9 @@ describe('sources/utils', () => {
it('returns null for invalid URLs', () => {
expect(parseGitHubUrl('https://gitlab.com/owner/repo')).toBeNull()
expect(parseGitHubUrl('not-a-url')).toBeNull()
expect(parseGitHubUrl('https://notgithub.com/owner/repo')).toBeNull()
expect(parseGitHubUrl('https://example.com/github.com/owner/repo')).toBeNull()
expect(parseGitHubUrl('https://github.com/owner/.git')).toBeNull()
})
})

Expand Down