You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
skilld self turns current workspace into a searchable project skill. It indexes source and docs, installs SKILL.md for selected agent, and makes skilld search "..." -p self return links back to real project files.
This is the useful one-shot part of #33. Watch mode can stay separate instead of blocking whole feature on file watcher.
Harlan Agent Kit posted this automated review. It is not Harlan's personal review or approval. AI open source policy. Human merge decision still required.
▓▓▓▓▓ 100%
Open: Persistent prompt injection: src/commands/self.ts:107..171 inserts untrusted project names, descriptions, and filenames into an auto-discovered SKILL.md. Lines 255..257 write it without the sanitizer used by normal skill generation.. Next: Parse and bound metadata, escape Markdown paths, sanitize the complete skill, and test malicious names, descriptions, and filenames.
Open: Invalid public skill output: line 180 uses sanitizeName, which permits dots, underscores, and 255 characters. Agent targets require 1 to 64 lowercase alphanumeric or hyphen characters. Descriptions also lack the 1024-character and angle-bra. Next: Use a specification-compliant skill identifier and bounded description. Test dotted, underscored, long, and angle-bracket inputs.
Open: Concurrent skilld self processes can corrupt or lose the last usable index. Lines 192..248 share fixed .next and .previous paths, delete them unconditionally, and provide no cross-process lock.. Next: Lock rebuilding per project, use unique temporary files, and atomically promote the completed database. Add a concurrent-builder regression test.
Open: Interactive self search prints a nonexistent path after selection. src/commands/search-interactive.ts:242 ignores referenceRoot and always emits a .claude path, although the result list uses the correct Codex or shared path.. Next: Reuse the referenceRoot-aware path formatter for selected results and test interactive selection output.
Open: The reserved self filter is not exclusive. src/commands/search-helpers.ts:18..22 still passes self into dependency matching, so packages such as selfsigned are searched alongside the project index.. Next: Return only the project database for the exact self filter. Add a lockfile regression containing a self-prefixed package.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
skilld selfturns current workspace into a searchable project skill. It indexes source and docs, installsSKILL.mdfor selected agent, and makesskilld search "..." -p selfreturn links back to real project files.This is the useful one-shot part of #33. Watch mode can stay separate instead of blocking whole feature on file watcher.