SK-3002 replace stale v3 naming in the flowvault artifact metadata - #405
Conversation
|
✅ Gitleaks Findings: No secrets detected. Safe to proceed! |
|
Semgrep Findings: Issues with Error level severity are found (Error is Highest severity in Semgrep), Please resolve the issues before merging. |
c5426cf to
e4b50f7
Compare
|
✅ Gitleaks Findings: No secrets detected. Safe to proceed! |
|
Semgrep Findings: Issues with Error level severity are found (Error is Highest severity in Semgrep), Please resolve the issues before merging. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #405 +/- ##
==========================================
Coverage 91.30% 91.30%
- Complexity 0 454 +454
==========================================
Files 157 157
Lines 6392 6392
Branches 850 850
==========================================
Hits 5836 5836
Misses 364 364
Partials 192 192
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
Devesh-Skyflow
changed the title
e4b50f7 to
f6a9176
Compare
|
✅ Gitleaks Findings: No secrets detected. Safe to proceed! |
Devesh-Skyflow
changed the title
|
Semgrep Findings: Issues with Error level severity are found (Error is Highest severity in Semgrep), Please resolve the issues before merging. |
"v3" was the module's directory name before the package split. Two consumer-visible strings still carried it. Maven Central description. The published POM for com.skyflow:skyflow-flowvault-java reads "Skyflow V3 SDK for the Java programming language", which means nothing to anyone browsing Central and matches neither the module README heading nor the parent POM's phrasing. Replaced with "Skyflow FlowVault SDK for the Java programming language" in pom.xml and in the checked-in dependency-reduced-pom.xml, which is the POM Maven actually deploys. The shade plugin regenerates that file at package time, so the build would pick the new text up either way, but the tracked copy was left stale and would otherwise show up as a spurious diff after any local build. Telemetry fallback. DEFAULT_SDK_VERSION is used when sdk.properties cannot be read, and feeds the sdk_name_version metric as "skyflow-flowvault-java@" + version. It was "v3", so the fallback path reported a version the artifact never had - flowvault is versioned 1.0.0, not 3.x. Set to "1.0.0" so the fallback matches what the normal path reports from sdk.properties. 1.0.0 is already published and its POM is immutable, so the corrected description only becomes visible on the next release. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
f6a9176 to
db0833e
Compare
|
✅ Gitleaks Findings: No secrets detected. Safe to proceed! |
|
Semgrep Findings: Issues with Error level severity are found (Error is Highest severity in Semgrep), Please resolve the issues before merging. |
1 participant
Problem
v3was the module's directory name before the package split. Two consumer-visible strings still carried it.1. The Maven Central description.
com.skyflow:skyflow-flowvault-javais described as "Skyflow V3 SDK for the Java programming language":It means nothing to anyone browsing Central, and matches neither the module README heading (
Skyflow FlowVault Java SDK) nor the parent POM'sSkyflow SDK for the Java programming language.2. The telemetry fallback.
DEFAULT_SDK_VERSIONis used whensdk.propertiescannot be read, and feeds thesdk_name_versionmetric as"skyflow-flowvault-java@" + version. It was"v3", so the fallback path reported a version the artifact never had — flowvault is versioned1.0.0, not3.x.Changes
1.0.0makes the fallback report the same value the normal path already resolves fromsdk.properties, so the two paths are indistinguishable in metrics.Verification
Editing
pom.xmlalone is sufficient for the deployed metadata. The POM Maven actually deploys is the shade plugin'sdependency-reduced-pom.xml(which is whycom.skyflow:commonis absent from the published POM — it is shaded into the jar). It regenerates atpackagetime, and the regenerated file is byte-identical to the POM on Central apart from this one line:Effective POM:
flowvault suite:
No test asserted on the old
"v3"value. (RequestIdTestscontains"v2"/"v3"string literals, but those are per-record payload values —v0…v3across four records — not module names.)Notes
1.0.0is already on Central and deployed POMs are immutable, so the existing listing keeps the old description permanently. The fix is visible from the next release onward.flowvault-release/26.8.1carries both stale strings too; since merges flowmain→flowvault-release, this should reach it on the next sync rather than needing a separate PR.flowvault/dependency-reduced-pom.xmlis a generated build artifact but is tracked in git, so any local build dirties the tree.skyvault/dependency-reduced-pom.xmlis untracked, so the two modules are inconsistent — worth gitignoring separately.🤖 Generated with Claude Code