0.17.1: staleCapture regression, imports type maps, renderToStringAsync - #224
Merged
Merged
Conversation
…, renderToStringAsync - reactivity: functions passed as call arguments don't escape through a return below them; sync array-method callbacks and IIFEs inside tracked computations no longer trigger staleCapture (#223) - imports: port the mixed JSX/Component split test from #222 - removed-api: report renderToStringAsync with migration guidance and scan @solidjs/web imports too; drop it from the v2 imports map (#222 follow-up) Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bug-fix patch, no new rules.
staleCaptureregression from 0.16.1: a function passed as a call argument doesn't escape through areturnbelow it, so synchronous array-method callbacks (items.filter((item) => item.includes(q))) and IIFEs insidecreateMemo/createEffectno longer flag. Regression tests from the issue repro, all four original staleCapture detections preserved.JSX, Componentsplit test from fix: map the JSX type to @solidjs/web in Solid 2.0 imports rule #222; movesrenderToStringAsyncout of the v2 imports map (it was autofixing imports into a dead end) and intosolid/removed-apiwith guidance (renderToStringawaits async content in 2.0).removed-apinow also scans@solidjs/webimports so mechanically source-rewritten imports of removed APIs are still reported.Also verified #193 fixed (closed) — signals passed as
create*arguments stopped warning with the 0.16.1 accessor-passing work.Test plan
PARSER=all: full plugin suite passes on typescript-eslint, babel, espreetsccleanMade with Cursor