Conversation
Add solid/no-unassigned-vars: ESLint's no-unassigned-vars, but a `ref={el}`
value counts as an assignment. The configs use it in place of the core rule,
which ESLint 10 enables in its recommended set.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #231.
ESLint 10's recommended
no-unassigned-varsreportslet el; <div ref={el} />. The compiler assignsel, but scope analysis only sees a read.This adds
solid/no-unassigned-vars. It uses the core rule's logic but counts aref={el}orref={el!}value as an assignment.recommended, and the configs that extend it, switch the core rule off in its favour.Tested: the new rule's tests pass on all parsers, and
pnpm cipasses. The repro from #231 now lints clean, while a genuinely unassignedletis still reported.