Skip to content

Add Solidus 3.4 support - #43

Open
tvdeyen wants to merge 2 commits into
solidusio-contrib:mainfrom
blish:solidus-3.4
Open

tvdeyen wants to merge 2 commits into
solidusio-contrib:mainfrom
blish:solidus-3.4

Conversation

@tvdeyen

@tvdeyen tvdeyen commented Mar 18, 2024

Copy link
Copy Markdown
Member

We stay below 4.0 and require at least 3.4 to make upgrading to v4.0 easier

We stay below 4.0 and require at least 3.4 to make upgrading
to v4.0 easier
We have renamed the default branch into main
@tvdeyen

tvdeyen commented Mar 18, 2024

Copy link
Copy Markdown
Member Author

CircleCI is not able to check out the code.

Directory (/home/circleci/project) you are trying to checkout to is not empty and not a git repository

https://app.circleci.com/pipelines/github/solidusio-contrib/solidus_gdpr/350/workflows/4f9292bd-083a-40ee-ad90-bdad1f49b7c5/jobs/773

Not sure what to do. Specs pass locally

Monosnap 2024-03-18 17-09-36

@tvdeyen

tvdeyen commented Mar 18, 2024

Copy link
Copy Markdown
Member Author

@elia @kennyadsl any ideas?

@kennyadsl

Copy link
Copy Markdown
Member

Hey Thomas, how different is the CircleCI config from the other working extensions?

@tvdeyen

tvdeyen commented Mar 19, 2024

Copy link
Copy Markdown
Member Author

Hey Thomas, how different is the CircleCI config from the other working extensions?

Good question, I have not created it.

But what I did was to lock the orb version to a version that still tests Solidus 3.4, because the latest version only tests Solidus 4 and this extension is not yet compatible with Solidus 4. It has not been updated for some time.

So, I hope to get some help from you guys, since you built the extension and maintain a lot of other extensions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants