Skip to content

refactor(tools/release): inline npm publish functionality into publishToNpm function #5429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marcoscaceres merged 4 commits into from
Aug 26, 2026
Merged

refactor(tools/release): inline npm publish functionality into publishToNpm function #5429

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5ebf550
harden: sanitize child_process call in release.cjs
anupamme Aug 25, 2026
a30324f
harden: rename toSpawnPromise → spawnNpm, remove executable parameter
anupamme Aug 25, 2026
5782916
harden: inline npm publish into publishToNpm(), remove args parameter
anupamme Aug 25, 2026
d15450d
Merge branch 'main' into fix-repo-respec-javascript-lang-security-det…
marcoscaceres Aug 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions tools/release.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -467,23 +467,22 @@ async function preflight() {
}

/**
* Runs a command interactively (stdio inherited), needed for npm publish OTP.
* @param {string} file
* Runs npm interactively (stdio inherited), needed for OTP auth during publish.
* @param {string[]} args
* @returns {Promise<void>}
*/
function toSpawnPromise(file, args) {
function spawnNpm(args) {
console.log(
styleText("cyan", `Run: ${file} ${styleText("grey", args.join(" "))}`)
styleText("cyan", `Run: npm ${styleText("grey", args.join(" "))}`)
);
if (DEBUG) return Promise.resolve();
return new Promise((resolve, reject) => {
const proc = spawn(file, args, { stdio: "inherit" });
const proc = spawn("npm", args, { stdio: "inherit", shell: false });
proc.on("close", code => {
if (code !== 0) {
reject(
new Error(
`Command failed with exit code ${code}: ${file} ${args.join(" ")}`
`Command failed with exit code ${code}: npm ${args.join(" ")}`
)
);
} else {
Expand Down Expand Up @@ -673,7 +672,7 @@ const run = async () => {

// 7. Publish to npm (interactive for OTP auth)
console.log(styleText("green", " Publishing to npm... 📡"));
await toSpawnPromise("npm", ["publish"]);
await spawnNpm(["publish"]);

// 8. Create GitHub Release (triggers W3C CDN sync)
console.log(styleText("green", " Creating GitHub Release... 📡"));
Expand Down
Loading