feat: add TrimUI PyUI media and fn settings - #1565
Conversation
Expose fn_editor for Smart Pro family devices and mirror Smart Pro display color settings with safe sysfs fallbacks on Smart Pro S.
Launch the firmware TinaPlayer via /usr/trimui/apps/player from PyUI Apps, and drop the mistaken display calibration changes on Smart Pro S.
Replace stock firmware app launches with themed PyUI menus: video browser plus ffplay playback, and Smart Pro Fn or switch toggles. Hide the legacy VideoPlayer wrapper and keep stock fneditor on Brick only.
Lazy-import Video Player and Fn settings in app_menu, and defer MiyooTrimCommon import until playback.
| brightness_up | ||
| fi | ||
| ;; | ||
| *"key $B_L3 1"*) # Left Fn key down |
There was a problem hiding this comment.
Does the fn-key have the same keycode as L3/R3?
Even if it does this should be slightly refactored to
- Have a new export for fn-key instead of reusing l3/r3
- Make a call to fn_key_down/fn_key_up
- in device.sh just make empty fn_key_down/up methods like all the others in there
- move the run_fn_config into SmartProS.sh and this call into fn_key_down/up methods from (3)
| return ControllerInput.R1 | ||
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
Are most of the line changes just line ending?
| ".mp4", ".mkv", ".avi", ".mov", ".flv", ".ts", ".webm", | ||
| ".m4v", ".wmv", ".mpeg", ".mpg", ".3gp", | ||
| } | ||
| VIDEO_ROOT = "/mnt/SDCARD/Roms/MEDIA" |
There was a problem hiding this comment.
Please update these to go through py-ui-config.json (located in App/PyUI/py-ui-config.json) and loaded through PyUiConfig.py
…ui-stock-settings # Conflicts: # App/PyUI/lang/English.json # App/PyUI/lang/Vietnamese.json # App/PyUI/main-ui/menus/app/app_menu.py
|
Updated branch Changes addressed:
Validation run:
Note: |
|
Created duplicate PyUI-only PR for MainPyUI: |
Resolve conflicts by keeping videoRootPath config, adopting upstream spruce-native backlight Fn script, and retaining Brick/BrickPro fn_editor device list.
|
Updated Merge
Review feedback status (still in place)
Validation
|
Sundownersport
left a comment
Sundownersport
left a comment
There was a problem hiding this comment.
Thanks for this, and sorry it's taken a while to get eyes on it. The write-up is genuinely one of the clearest PR descriptions we've had — having the actual on-device verification steps in there made reviewing it much easier. The problem is real too: Fn slider CPU mode not applying on Smart Pro S has come up before, and PyUI-native media/Fn screens are something people have asked for.
I'd like to get this in. Here's what I think needs to happen first.
The one that blocks merge
buttons_watchdog.sh is shared by every device, and dip_switch_bg & is started unconditionally at top level. On anything that isn't a Smart Pro S — A30, Mini, Flip, Anbernic — that leaves a 5 Hz poll loop running forever with nothing to read. The part I'd want to avoid shipping is this:
echo 363 > /sys/class/gpio/export
echo -n in > /sys/class/gpio/gpio363/directionGPIO 363 is a Smart Pro S pin. On another SoC that number is something else entirely, and we'd be exporting and reconfiguring it on every boot. Could this go behind a device function, the way the rest of the platform-specific behaviour works? Starting the poller from device_functions/SmartProS.sh would keep it off hardware that has no business running it.
Fn key dispatch — we have a pattern for this now
This is entirely on our timing rather than yours: spruce/brick/fnkey_watchdog.sh landed on 2026-07-07, five days after you opened this PR, so it wasn't there when you started. It solves the same problem — spruce doesn't run keymon, so the Fn keys do nothing — as a standalone watchdog that reads /usr/trimui/fnkeys/f1key_launch, has an outer restart loop, uses getevent -pid $$, and logs through log_message.
Right now this PR would give two sibling TrimUI devices two different implementations with two different data models (f1key_launch plain text vs f1key.json + jq). Would you be up for converging on that one? Smart Pro S mostly needs the launcher wired up plus your DIP handling, which the Brick doesn't have.
Thermal profile writes
I don't think these are landing the way you'd expect:
set_thermal_profile sport/conservative— the profiles directory only hashigh.json,low.json,medium.json,off.json, so those names don't resolve to anything.active_profileis normally written byspruce/smartpros/bin/update-thermal-watchdog-to-setting, which stops the watchdog binary, writes the file, then restarts it. Writing the file on its own means the running watchdog never re-reads it.- It also puts the file out of sync with
spruce-config.json, so the Thermal Control option in System Settings would disagree with what's on disk and quietly overwrite it on the next settings change or reboot.
My suggestion would be to drop the thermal bits from this PR entirely and do them separately through that entry point — it keeps this PR much easier to reason about.
Smaller things
pkill -f "$(basename "$scene")"matches on full command line, so a generically-named scene script could take unrelated processes with it.- Debug logging —
/tmp/buttons_watchdog_dip.logand_fn.loggrow unbounded in RAM, andecho "$line" > /tmp/buttons_watchdog_last_eventis a file write on every input event on every device. I'm guessing these were for the SSH testing and just need pulling back out. - The lang files got reindented from 4-space to 2-space, which turned ~40 real new strings into ~860 lines of diff (431 of the 432 removed lines are byte-identical to added ones). Same whitespace churn in
app_menu.pyandpy-ui-config.json. Could you restore the original indentation and keep just the new keys? It'll make this much easier to review and stop it conflicting with other translation work. - Device gating —
app_menu.pyhardcodes("TRIMUI_SMART_PRO_S", "TRIMUI_SMART_PRO", "TRIMUI_BRICK")in Python, but there's already the declarative route that your ownApp/VideoPlayer/config.jsonuses ("devices": [...], read atapp_menu.py:91). Worth using that for consistency. AlsoTRIMUI_BRICK_PROis missing from the video player list — it's a supported device and would silently miss out. App/VideoPlayerships with"hide": trueand "Deprecated: use PyUI Video Player" from day one. If it's only there for the icon and the stock-player fallback, maybe worth saying so in a comment, or moving the icon somewhere less surprising.com.trimui.cpuperformance.shandcom.trimui.cpusave.share ~90% the same file. One script taking a mode argument would be easier to keep in step.
One to double-check
The scripts set cpu4 directly to performance 1992000 1992000. Have you checked how that interacts with set_smart / enforceSmartCPU.sh? If spruce's CPU management reasserts afterwards, we'd get intermittent "my clocks reset themselves" reports that are miserable to track down. You may well have already confirmed this on device — if so, ignore me.
Structure I liked
The fn_key_down / fn_key_up no-op in device.sh with per-device overrides is exactly right and matches how the rest of the platform layer works. And shipping Vietnamese alongside English is appreciated — not many contributors do that.
Heads up that Development has moved about 52 commits since your base, so this'll want a rebase whenever you pick it back up. No rush from my side, and happy to talk through any of the above if you'd rather approach it differently — particularly the Fn dispatch question, since that's more about which direction we standardise on than about anything being wrong with your version.
|
this is Claudes review btw, feel free to reach out with any questions or concerns! |
3 participants
Why
TrimUI Smart Pro/S users need PyUI-native access to stock-like video playback and Fn/DIP switch settings without falling back to the stock TrimUI UI. The stock CPU scene scripts also fail under spruceOS because CPU sysfs controls are locked and some stock frequencies are invalid on Smart Pro S, so Fn slider CPU performance mode does not apply reliably.
What Changed
/mnt/UDISK/system.json.buttons_watchdog.shto poll GPIO363 for Fn slider/DIP changes, run scene scripts, and stop prior scene script instances before starting new ones.Verification
git diff --checksuccessfully.python -m py_compilefortrimui_fn_settings_app.py,video_player_app.py, andapp_menu.pysuccessfully./tmp/buttons_watchdog_dip.logrecordedstate 1andstate 0transitions.performance 1992000 1992000for performance state and returns toondemand 1008000 1992000for normal state.