fix: release peer lock before persistence - #101
Open
ovitrif wants to merge 2 commits into
Open
Conversation
Backport lightningdevkit/ldk-node@d49b681 while preserving fork address updates and retryable persistence failures.
ovitrif
force-pushed
the
ovi/fix-99-release-peer-lock
branch
from
July 29, 2026 13:02
85ac71a to
b3bd780
Compare
ovitrif
marked this pull request as ready for review
July 29, 2026 13:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #99
Related to synonymdev/bitkit-android#986.
Addresses the
Node.listPeersANR tracked in synonymdev/bitkit-android#1036.Summary
KVStorepersistence lightningdevkit/ldk-node#919's asyncKVStorepeer-persistence design.RwLock, and release that lock before awaiting persistence.0.7.0-rc.61.Validation
cargo fmt --check,git diff --check, andcargo test --features uniffi --lib(93 passed)../bindgen.shcompleted for JVM Kotlin, Python, Swift, and Android; JVM Gradle, Swift framework assembly, Android three-ABI build-ID, 16 KiB alignment, debug-symbol, stripped-library, and AAR checks passed.8662cdf7f52725ceab0ebf68b7ded139dfbbb0b4b5ec4e451cb5f7cce505ce68matchesPackage.swiftand the uploaded release asset.QA Notes
Release