Skip to content
This repository was archived by the owner on Aug 27, 2026. It is now read-only.

fix: resolved accuracy decimal overflow #302

Draft
SykikXO wants to merge 2 commits into
base: develop
Choose a base branch
from
Draft

fix: resolved accuracy decimal overflow #302

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ee4ab57
fix: resolved accuracy decimal overflow
SykikXO Apr 3, 2026
5fccad6
fix: format accuracy as String, strip trailing .0
SykikXO Apr 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions ...ua/syt0r/kanji/presentation/screen/main/screen/practice_letter/LetterPracticeViewModel.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ package ua.syt0r.kanji.presentation.screen.main.screen.practice_letter
import androidx.compose.runtime.State
import androidx.compose.runtime.mutableStateOf
import androidx.compose.runtime.snapshotFlow
import kotlin.math.roundToInt
import kotlinx.coroutines.CoroutineScope
import kotlinx.coroutines.channels.awaitClose
import kotlinx.coroutines.delay
Expand All @@ -28,8 +29,6 @@ import ua.syt0r.kanji.presentation.screen.main.screen.practice_letter.use_case.G
import ua.syt0r.kanji.presentation.screen.main.screen.practice_letter.use_case.GetLetterPracticeQueueDataUseCase
import ua.syt0r.kanji.presentation.screen.main.screen.practice_letter.use_case.GetLetterPracticeReviewStateUseCase
import ua.syt0r.kanji.presentation.screen.main.screen.practice_letter.use_case.UpdateLetterPracticeConfigurationUseCase


class LetterPracticeViewModel(
private val viewModelScope: CoroutineScope,
private val getConfigurationUseCase: GetLetterPracticeConfigurationUseCase,
Expand Down Expand Up @@ -123,14 +122,16 @@ class LetterPracticeViewModel(
}

private fun LetterPracticeQueueState.Summary.toScreenState(): ScreenState.Summary {
val accuracy: Float? = items.filterIsInstance<LetterPracticeSummaryItem.Writing>()
val accuracy: String? = items.filterIsInstance<LetterPracticeSummaryItem.Writing>()
.takeIf { it.isNotEmpty() }
?.let {
val totalStrokeCount = it.fold(0) { sum, item -> sum + item.strokeCount }
val totalMistakeCount = it.fold(0) { sum, item -> sum + item.mistakes }
val correctStrokes = (totalStrokeCount - totalMistakeCount)
.coerceAtLeast(0)
correctStrokes.toFloat() * 100 / totalStrokeCount
(correctStrokes.toFloat() * 100f / totalStrokeCount).let {
((it * 100).roundToInt() / 100f).toString().removeSuffix(".0")
}
}
return ScreenState.Summary(
duration = duration,
Expand Down