CHI-3982: Tweak PhoneInputDialog UI on QA feedback - #4676
Merged
Conversation
# Conflicts: # plugin-hrm-form/src/components/Conference/ConferenceActions/PhoneInputDialog.tsx
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The updated close button introduces a hard-coded aria-label that overrides localized screen-reader text, impacting accessibility/localization.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Updates the Conference “Add participant” phone input dialog UI to align with QA feedback by standardizing form controls and adjusting header/footer visuals within the existing HRM form styling system.
Changes:
- Replaced the dialog’s quick-dial
<select>styling with sharedFormSelect/FormOptioncomponents from the global styles. - Updated the dialog header close control to use
HeaderCloseButtonwith a close icon and screen-reader text. - Tweaked the dial button icon sizing/spacing.
File summaries
| File | Description |
|---|---|
| plugin-hrm-form/src/components/Conference/ConferenceActions/styles.ts | Removes the dialog-specific QuickDialSelect in favor of shared form select styles. |
| plugin-hrm-form/src/components/Conference/ConferenceActions/PhoneInputDialog.tsx | Switches quick-dial to shared form select components; updates close button and icon styling. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+135
to
+139
| <HeaderCloseButton | ||
| buttonRef={focusRef} | ||
| onClick={() => setIsDialogOpen(false)} | ||
| style={{ marginLeft: 'auto', marginRight: 0, paddingRight: 0 }} | ||
| /> | ||
| aria-label="CloseButton" | ||
| style={{ marginLeft: 'auto', marginRight: -16, marginBottom: 4, paddingRight: 0 }} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
https://tech-matters.atlassian.net/browse/CHI-3982?focusedCommentId=37376 - addressing all except point 3
Checklist
Other Related Issues
None
Verification steps
AFTER YOU MERGE
You are responsible for ensuring the above steps are completed. If you move a ticket into QA without advising what version to test, the QA team will assume the latest tag has the changes. If it does not, the following confusion is on you! :-P