ipc4: helper: fix buffer core assignment for cross-core binds - #11048
Merged
lgirdwood merged 1 commit intoJul 30, 2026
Conversation
This fixes a regression introduced by bde2726 ("ipc4: add user-space command-forwarding context") which replaced ipc_buf.comp.core = cpu_get_id(); with ipc_buf.comp.core = src->ipc_config.core; The replacement was needed to prepare the function to be called from user space, where cpu_get_id() is privileged. However, it broke the cross-core bind case: such a bind is always processed on the primary core, so the two expressions are not equivalent there. Signed-off-by: Serhiy Katsyuba <serhiy.katsyuba@intel.com>
serhiy-katsyuba-intel
requested review from
dbaluta,
kv2019i,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
July 30, 2026 15:09
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes an IPC4 regression affecting cross-core binds by restoring correct buffer core assignment while keeping the helper safe for potential user-space invocation (i.e., avoiding privileged cpu_get_id() in the assignment logic).
Changes:
- Assign the created buffer’s
comp.coretoPLATFORM_PRIMARY_CORE_IDfor cross-core binds (processed on the primary core), otherwise tosrc->ipc_config.core. - Update/assert the core expectation based on the computed buffer core and document the same-core vs cross-core execution behavior.
tmleman
approved these changes
Jul 30, 2026
lgirdwood
approved these changes
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a regression introduced by
bde2726 ("ipc4: add user-space command-forwarding context") which replaced
with
The replacement was needed to prepare the function to be called from user space, where cpu_get_id() is privileged.
However, it broke the cross-core bind case: such a bind is always processed on the primary core, so the two expressions are not equivalent there.