Skip to content

fix(web): provide exact PWA icon sizes for Windows notifications - #1625

Open
techotaku39 wants to merge 1 commit into
tiann:mainfrom
techotaku39:fix/web-pwa-notification-icon
Open

fix(web): provide exact PWA icon sizes for Windows notifications#1625
techotaku39 wants to merge 1 commit into
tiann:mainfrom
techotaku39:fix/web-pwa-notification-icon

Conversation

@techotaku39

Copy link
Copy Markdown
Contributor

Problem / Motivation

On Windows 10, an Edge-installed HAPI PWA uses the PWA application icon for the small identity icon in notification toasts. The manifest did not provide sufficiently small exact-size resources, so Windows/Edge downscaled a larger icon and the identity icon appeared blurry.

The larger notification body icon was already clear and is not changed by this PR.

Summary

  • Add 16x16, 24x24, 32x32, and 48x48 PNG PWA icon assets.
  • Advertise the new exact sizes in the Vite PWA manifest while retaining the existing 64x64, 192x192, and 512x512 assets.
  • Leave notification payloads, Service Worker behavior, and the body icon unchanged.

Validation

  • bun typecheck
  • pwsh -NoProfile -File .\scripts\Invoke-HapiTaskPlaywright.ps1 -Name pwa-notification-icon -Suite Root -TestArgs terminal-wrap-fidelity.spec.ts — 2 passed
  • bun run test:web — 264 files, 2,555 tests passed
  • bun run build — passed
  • Manual Windows 10 + Edge validation with a fresh PWA installation and a real Web Push notification confirmed that the top-left identity icon is sharp while the body icon remains sharp.
  • Deployed manifest and icon resources returned HTTP 200.

Impact / Risk

  • No notification logic or data format changes.
  • Existing installed PWAs may need to be reinstalled or refreshed because Edge caches PWA icons.

Related Issues

Fixes #1622

AI Disclosure

OpenAI Codex assisted with the implementation, validation, and PR drafting.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Findings

  • None.

Summary

  • Review mode: initial. No correctness, security, regression, data-loss, performance, or maintainability issues found in the latest diff. Residual risk: Windows/Edge notification identity-icon selection and installed-PWA icon-cache refresh are platform-specific; no automated manifest/icon-dimension assertion was found around web/vite.config.ts:105.

Testing

  • Not run (automation). GitHub integration passed; test was pending at review time. The four PNG dimensions and manifest declarations were inspected directly.

HAPI Bot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug(web): blurry HAPI icon in Windows Edge PWA notifications

1 participant