fix(web): provide exact PWA icon sizes for Windows notifications - #1625
Open
techotaku39 wants to merge 1 commit into
Open
fix(web): provide exact PWA icon sizes for Windows notifications#1625techotaku39 wants to merge 1 commit into
techotaku39 wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Findings
- None.
Summary
- Review mode: initial. No correctness, security, regression, data-loss, performance, or maintainability issues found in the latest diff. Residual risk: Windows/Edge notification identity-icon selection and installed-PWA icon-cache refresh are platform-specific; no automated manifest/icon-dimension assertion was found around
web/vite.config.ts:105.
Testing
- Not run (automation). GitHub
integrationpassed;testwas pending at review time. The four PNG dimensions and manifest declarations were inspected directly.
HAPI Bot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem / Motivation
On Windows 10, an Edge-installed HAPI PWA uses the PWA application icon for the small identity icon in notification toasts. The manifest did not provide sufficiently small exact-size resources, so Windows/Edge downscaled a larger icon and the identity icon appeared blurry.
The larger notification body icon was already clear and is not changed by this PR.
Summary
Validation
bun typecheckpwsh -NoProfile -File .\scripts\Invoke-HapiTaskPlaywright.ps1 -Name pwa-notification-icon -Suite Root -TestArgs terminal-wrap-fidelity.spec.ts— 2 passedbun run test:web— 264 files, 2,555 tests passedbun run build— passedImpact / Risk
Related Issues
Fixes #1622
AI Disclosure
OpenAI Codex assisted with the implementation, validation, and PR drafting.