Conversation
|
Mythofs is my other account |
aarushtools
left a comment
There was a problem hiding this comment.
Hi Bryan,
Good start on your PR, can you just review the comments I added? Thanks!
Also just to be sure you covered most of these cases, what was your process for finding them?
| self.stdout.write(str(usr.delete())) | ||
| username = usr.username | ||
| delete_count, deleted_objects = usr.delete() | ||
| self.stdout.write(f"Deleted user {username}, {delete_count} objects deleted {deleted_objects}") |
There was a problem hiding this comment.
can you show an example of what this output looks like? I am worried this will be unnecessarily long
There was a problem hiding this comment.
It will output something like this, but deleted_objects will probably be a lot longer for actual users:
Deleted user 2026banderso, 2 objects deleted {'users.Email': 1, 'users.User': 1}
Deleted user 2026dbaker, 2 objects deleted {'users.Email': 1, 'users.User': 1}
Deleted user 2026abrown, 2 objects deleted {'users.Email': 1, 'users.User': 1}
To make it more compact, deleted_objects could be removed.
|
To find log statements, I ran this command: I wasn't sure if I had to add context to error logs so I ignored them |
Proposed changes
Brief description of rationale
Closes #729