fix(import): align json and csv import with our guidelines and export - #3163
Open
seferturan wants to merge 9 commits into
Open
fix(import): align json and csv import with our guidelines and export#3163seferturan wants to merge 9 commits into
seferturan wants to merge 9 commits into
Conversation
Third-party exports send numeric ids as strings ("tmdb_id": "67324"). The
JSON parser passed them straight through, so the sync payload shipped a
string where Trakt expects an integer and the item silently matched nothing.
Both flat entry shapes hardcoded a movie type, so a documented "type": "show" or "episode" was silently discarded and the item went out as a movie lookup against a TMDB id from the show namespace. Only the nested movie/show/episode wrapper ever reached toType.
Only movies had tmdb in their id priority, so a show or episode carrying nothing but a tmdb id resolved to nothing and was dropped from the payload. Both are supported server side: find_by_multi resolves a show by trakt/imdb/tmdb/tvdb and an episode by trakt/tmdb/tvdb/imdb. Inserted ahead of trakt only, so anything that already resolved keeps resolving to the same id.
A single entry can carry a watch, a rating and a watchlist date at once, as the documented example does. inferAction only ever returned one of them, so an entry with both watched_at and a rating was counted and imported as a rating alone and the watch was dropped. The CSV parser already fans these out; JSON now matches.
The guide has always listed season as a valid type, but toType had no branch for it so a season entry parsed as a movie, and none of the payload builders had a seasons bucket. Seasons resolve by trakt, tmdb or tvdb id server side, never imdb, hence the SEASON_IDS priority.
buildWatchlistPayload only ever emitted movies and shows, so a watchlisted episode was dropped without a trace. It also backs syncLists, so episodes were missing from imported custom lists too.
buildRatingsPayload only emitted movies and shows, so an episode rating was dropped even though the guide documents rating for every type and the sync endpoint takes an episodes bucket.
An episode carrying only an imdb id had nowhere to go, so it was pushed into the shows bucket under that id. No show carries an episode's imdb id, so the entry either vanished or, worse, marked a whole show watched. Episodes do resolve by imdb server side, so route them as episodes and drop the punt. Fixes IMDb tvEpisode rows, which only ever carry an episode imdb id.
An export names its entries watched-history-1.json, ratings-movies-1.json and lists-watchlist.json, but the zip reader only looked for watched/history*, ratings/ratings* and lists/watchlist.json. Nothing matched, so dropping a raw export on the JSON tab imported zero items. Separators are folded together rather than swapped, so the v2 layout keeps working for anyone holding an older export.
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code review is billed via overage credits. To resume reviews, an organization admin can raise the monthly limit at claude.ai/admin-settings/claude-code.
Once credits are available, reopen this pull request to trigger a review.
 |
|
Overall Grade |
Security Reliability Complexity Hygiene Coverage  |
Code Review Summary
| Analyzer | Status | Updated (UTC) | Details |
|---|---|---|---|
| JavaScript |  |
Aug 20, 2026 6:59p.m. | Review ↗ |
| Code coverage | |
Aug 20, 2026 6:59p.m. | Review ↗ |
Code Coverage Summary
| Language | Line Coverage (Overall) |
|---|---|
| Aggregate | 69.3% |
| Javascript | 69.3% |
➟ Additional coverage metrics may have been reported. See full coverage report ↗
Important
AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎶 Notes 🎶
Collection of fixes so the JSON and CSV importers support what our own guidelines document, and can ingest our own export.
Guidelines
*_identries droppedtype. A documented"type": "show"went out as a movie lookup against a TMDB show id, so no match, or a match on an unrelated movie.type: "season"was documented but never implemented. No branch intoType, no seasons bucket anywhere.tmdbin their id priority, so a show or episode carrying just atmdb_idresolved to nothing and was dropped.imdb. They were pushed into theshowsbucket under an episode imdb id, which no show carries, so they vanished or marked a whole show watched. Also fixes IMDbtvEpisoderows.episodesbucket, so episode ratings and watchlisted episodes were dropped.inferActiononly ever returned one of them. CSV already fanned these out, JSON now matches."tmdb_id": "67324") are coerced at the parse boundary.to_s, so they did resolve.Export
watched/history*,ratings/ratings*andlists/watchlist.json. Exports name their entrieswatched-history-1.json,ratings-movies-1.jsonandlists-watchlist.json, so nothing matched and a raw export imported zero items.season.ids, sibling to ashow. Those were falling through to the show's ids.Verified
Follow ups
@trakt/apiepisode ids omittmdbandimdb, and seasontmdbis typed as a string. All wrong againstfind_by_multi, the payload builders cast around it for now.