Added support for additional validation rules in custom detector#4413
Merged
kashifkhan0771 merged 9 commits intoAug 26, 2025
Conversation
nabeelalam
reviewed
Aug 21, 2025
nabeelalam
reviewed
Aug 21, 2025
kashifkhan0771
marked this pull request as ready for review
August 21, 2025 14:44
shahzadhaider1
approved these changes
Aug 22, 2025
peterfraedrich
pushed a commit
to peterfraedrich/trufflehog
that referenced
this pull request
Mar 15, 2026
…fflesecurity#4413) * Added support for additional validation rules in custom detector * refactored the approach to support validations for each regex in config * resolved comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds support for validation rules in custom detectors to reduce false positives.
Problem:
Go's RE2 regex engine lacks support for lookahead assertions (e.g., (?=.*[0-9])), making it impossible to validate that detected secrets contain specific character types like digits, uppercase letters, or special characters. This limitation often leads to false positives when detecting API keys, passwords, and tokens that should follow specific rules.
Solution:
Added a new validations field to the Custom detector configuration that supports the following validation types:
Example Usage:
Checklist:
make test-community)?make lintthis requires golangci-lint)?