site: version-control the landing page + fix social/SEO URLs - #2
Merged
Conversation
The landing page was live on Vercel but its source (index.html, og.svg, README.md) lived only in a local worktree, untracked. Commit it so the deploy is reproducible from GitHub — matching the site README's "import tshiv/pushback, root directory site" instructions. Also fix the social/SEO tags, which pointed at a GitHub Pages URL the site was never deployed to: - canonical + og:url → https://pushback-swart.vercel.app/ - og:image + twitter:image → absolute URL (relative paths don't resolve for most social scrapers) Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Review fixes on the landing page:
- Terminal demo: drop `term.classList.add("run")` from play(). The
`.term.run .ln` rule (0-3-0) outranks `.term-body .ln` (0-2-0), so
adding `run` before the lines exist made each one compute to
opacity:1 on append — the rAF reveal set the same value and the
transition never fired. Without the class, lines fade in as intended.
- Flight plan: add the "Sync main" leg. The real script has 8 steps
(Sync main is step 4) and the terminal demo + "Eight steps" heading
already say 8; the legs array only had 7. Adjusted the Merge copy so
it no longer pre-claims the pull that Sync main does.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Rewrote the Sync main leg to match the sibling legs' rhythm (short stacked sentence, causal "so") and remove the em dash per the hard no-em-dash rule in the voice profile. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Brings the pushback landing page into the repo. It was already live at pushback-swart.vercel.app but its source only existed in a local worktree, untracked — so the deploy wasn't reproducible from GitHub, and the site README's "import
tshiv/pushback→ root directorysite" instructions couldn't actually work.Changes
Commit
site/(index.html,og.svg,README.md) — one self-contained static page, no build step.Fix social/SEO tags that pointed at a GitHub Pages URL the site was never deployed to:
canonicaltshiv.github.io/pushback/pushback-swart.vercel.app/og:urltshiv.github.io/pushback/pushback-swart.vercel.app/og:image/twitter:imageog.svg(relative)Relative
og:imagepaths don't resolve for most social scrapers, so link previews would have been broken regardless of the URL.Notes
PUSHBACK_SIM_DEVICEUDID fix is in[Unreleased], not shipped).og.svgfor a 1200×630 PNG for guaranteed iMessage/Twitter previews (the site README already tracks this).🤖 Generated with Claude Code