metadata access counter; closes #3472 - #3475
Open
petrelharp wants to merge 2 commits into
Open
Conversation
petrelharp
force-pushed
the
metadata_cache
branch
from
August 7, 2026 14:28
c9090a1 to
d061de1
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3475 +/- ##
=======================================
Coverage 91.67% 91.68%
=======================================
Files 38 38
Lines 32188 32214 +26
Branches 5151 5157 +6
=======================================
+ Hits 29509 29535 +26
Misses 2346 2346
Partials 333 333
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
petrelharp
marked this pull request as ready for review
August 7, 2026 17:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As lengthily discussed in #3472, if top-level metadata is large then doing
ts.metadataa lot of times can be verrrrry slow, because of both the decoding and making a copy of the data (in roughly equal measure). Seeing no straightforward way around this, I'm proposing this stopgap: if someone doesTreeSequence.metadataorTableCollection.metadata20 times then they get a Warning suggesting they do something else. The warning only occurs once.