[pull] master from ruby:master - #1405
Merged
Merged
Conversation
Extracted from ruby/erb#141 and ruby/erb#144 ruby/erb@182850a467 Co-Authored-By: Scott Myron <samyron@gmail.com>
…match Now the caller is responsible for consuming the match using `consume_match`, which means the undefined behavior `matches_bitmap >>= 64` is no longer a concern, eliminating a condition. ruby/erb@40a8edea18
(ruby/prism#4220) Sort of a followup for ruby/prism@929aec1 It changed the value for `:''` into nil/null, which is a bit inconvenient. For syntax-valid code I expect it to always be present. It's also inconsistent with `StringNode`. In effect, this reverts the snapshots changes and the two changes in ruby for the ripper/parser compiler. ruby/prism@531cd5e557
similar (ruby/prism#4226) This tries to coerce with `to_path` and then `to_str` if it isn't a string already. I had a `Pathname` from some other source and was sad I couldn't simply pass it along ruby/prism@4651adbaeb
TracePoints that are enabled but never disabled in a Ractor leak memory.
For example, the following script leaks memory:
10.times do
1_000.times do
Ractor.new {
200.times { TracePoint.new(:call) { }.enable }
}.value
GC.start
end
puts `ps -o rss= -p #{$$}`
end
Before:
32180
47868
63492
79116
94744
110368
125992
141616
157244
172868
After:
16428
16492
16492
16492
16492
16492
16492
16492
16492
16492
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )