4400 remove hardcoded bc20m and tc0m

[chris-ashe]

Description

Checklist

I confirm that I have completed the following checks:

• My changes follow the PROCESS style guide
• I have justified any large differences in the regression tests caused by this pull request in the comments.
• I have added new tests where appropriate for the changes I have made.
• If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments.
• If I have made documentation changes, I have checked they render correctly.
• I have added documentation for my change, if appropriate.

[codecov-commenter]

Codecov Report

❌ Patch coverage is 38.98305% with 36 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.30%. Comparing base (2a4d69b) to head (a71bb81).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
process/models/stellarator/coils/coils.py	4.54%	21 Missing ⚠️
process/models/pfcoil.py	42.85%	8 Missing ⚠️
process/models/tfcoil/superconducting.py	37.50%	5 Missing ⚠️
process/models/superconductors.py	86.66%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4478      +/-   ##
==========================================
+ Coverage   49.20%   49.30%   +0.09%     
==========================================
  Files         152      150       -2     
  Lines       29835    29778      -57     
==========================================
+ Hits        14681    14682       +1     
+ Misses      15154    15096      -58     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[clmould]

A few small things

[clmould]

1 tiny thing

[clmould]

Found a few remaining hard-coded values to be updated to use the SuperconductorModel values instead. Also 2 more things:

• There are some hard coded values in documentation/plotting_scripts - could these be updated to use the SuperconductorModel too please?

• Also one instance of jcrit_rebco needs the new args adding still in 2nd_gen_rebco_critical_surface.py (can they be done as keyword args please):

[clmould]

There are some cases in this file where the numbers are hard-coded still, could these be updated to use the SuperconductorModel values please? Just so they all use the values from the enum for consistency

• In superconparam in expected_bc20m and expected_tc0m

• Also can they be used here too?

[clmould]

In documentation/scripts/plotting_scripts/old_empirical_nbti_critical_surface.py, can the args b_c20max and temp_c0max in jcrit_nbti() use the SuperconductorModel please:

[clmould]

Could superconparam for test_supercon() use the SuperconductorModel for expected_bc20m and expected_tc0m too please?