Add sol outboard enum - #4514
Open
chris-ashe wants to merge 9 commits into
Open
Conversation
…ntegrate power decay length logic in ScrapeOffLayer model
chris-ashe
added
Refactor
Scrape off Layer
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4514 +/- ##
==========================================
+ Coverage 49.13% 49.31% +0.18%
==========================================
Files 152 150 -2
Lines 29806 29804 -2
==========================================
+ Hits 14644 14697 +53
+ Misses 15162 15107 -55 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
timothy-nunn
requested changes
Aug 13, 2026
| self.data.physics.len_plasma_sol_mast14_power_decay_2 | ||
| ) | ||
|
|
||
| self.data.physics.a_plasma_outboard_sol_parallel = self.calculate_upstream_sol_outboard_parallel_area( # noqa: E501 |
Collaborator
There was a problem hiding this comment.
You can use parentheses to put the function call on the next line and remove the need to use noqa statement
| b_plasma_surface_poloidal_average=self.data.physics.b_plasma_surface_poloidal_average, | ||
| ) | ||
|
|
||
| self.data.physics.a_plasma_outboard_sol_eich13_parallel = self.calculate_upstream_sol_outboard_parallel_area( # noqa: E501 |
Collaborator
There was a problem hiding this comment.
Can we do this here too
| ) | ||
| po.ocmmnt( | ||
| self.outfile, | ||
| f"-> {OutbordSOLPowerDecayLengthModel(self.data.physics.i_len_sol_outboard_power_decay).description} ", # noqa: E501 |
Collaborator
There was a problem hiding this comment.
Again, not a fan of skipping line length checks because it could be avoided here
Comment on lines
+12
to
+14
| EICH_2013 = (0, "Eich 2013") | ||
| MAST_2014_1 = (1, "MAST 2014-1") | ||
| MAST_2014_2 = (2, "MAST 2014-2") |
Collaborator
There was a problem hiding this comment.
Are the actual models referenced in the docs? If not, can we add a docstring here that does so.
Collaborator
Author
There was a problem hiding this comment.
…ayer logic for user input handling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Checklist
I confirm that I have completed the following checks: