docs: remove stale block device TODO in firecracker.go - #1022
Open
magic-peach wants to merge 1 commit into
Open
Conversation
Block devices are already implemented in the lines right below this comment. Fixes: urunc-dev#1013 Signed-off-by: Akanksha Trehun <akankshatrehun@gmail.com>
✅ Deploy Preview for urunc ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
Author
|
@cmainas could you please take a look at this pr as well when you get time? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes a stale TODO comment above the Firecracker block device setup code. The comment claims block device support is missing, but the loop right below it already builds FirecrackerDrive entries from ukernel.MonitorBlockCli(), including marking the root device. Block devices are already supported and documented.
Related issues
How was this tested?
Comment only change. Ran go build and golangci-lint for the package to confirm nothing else needed touching.
LLM usage
none
Checklist
make lint).make test_ctr,make test_nerdctl,make test_docker,make test_crictl).