Skip to content

fix: restore binaries corrupted by eol normalization and harden .gitattributes#2364

Merged
osmontero merged 1 commit into
v11from
backlog/restore-binaries-eol-corruption
Jul 21, 2026
Merged

fix: restore binaries corrupted by eol normalization and harden .gitattributes#2364
osmontero merged 1 commit into
v11from
backlog/restore-binaries-eol-corruption

Conversation

@yllada

@yllada yllada commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

How it was fixed

  • Corrupted files were identified with git diff d2576cfc2^ d2576cfc2 --numstat (binary files show - instead of line counts), so the restore covers exactly the files git damaged.

@yllada
yllada requested a review from a team July 21, 2026 17:44
@osmontero
osmontero merged commit ea4f060 into v11 Jul 21, 2026
5 checks passed
@osmontero
osmontero deleted the backlog/restore-binaries-eol-corruption branch July 21, 2026 17:45
@github-actions

Copy link
Copy Markdown

🛑 AI review — Engineer review required

This PR touches critical paths or introduces changes the model cannot judge with sufficient confidence. @Kbayero @osmontero please review.

🛑 architecture (gemini-3-flash-lite) — blocking — must fix before merge

Summary: Modification of agent binary resources (.syso) requires Tier 3 review as it impacts agent builds and potentially agent-server compatibility.

  • high agent/rsrc_windows_386.syso:0 — Modification of agent binary resource files. Changes to agent build artifacts must be treated as Tier 3 to ensure compatibility with existing deployed agents.
  • high agent/rsrc_windows_amd64.syso:0 — Modification of agent binary resource files. Changes to agent build artifacts must be treated as Tier 3 to ensure compatibility with existing deployed agents.
  • high agent/updater/rsrc_windows_386.syso:0 — Modification of agent updater binary resource files. This is a critical path that could break auto-update functionality for deployed agents.
  • high agent/updater/rsrc_windows_amd64.syso:0 — Modification of agent updater binary resource files. This is a critical path that could break auto-update functionality for deployed agents.

⚠️ bugs (gemini-3-flash-lite) — non-blocking warnings

Summary: Updated .gitattributes to correctly handle binary files and updated various binary assets.

  • low frontend/src/assets/img/guides/google/create_shirnk.png:0 — Typo in filename: 'shirnk' → 'shrink'. While this is a filename, it appears to be part of a documentation guide path.

security (gemini-3-flash-lite) — clean

Summary: The PR consists exclusively of binary asset updates and configuration changes to .gitattributes, with no code changes or security vulnerabilities introduced.

No findings.

@utmstackprapprover utmstackprapprover Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes requested — AI review found blocking issues (high/critical, or engineer review required). See above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants