fix(filters): normalize actionResult to canonical values#2366
Open
JocLRojas wants to merge 1 commit into
Open
Conversation
…ked/failed/success) across ESET, Azure, Meraki, GCP, Linux, O365 and Sophos
✅ AI review — ApprovedNo issues detected in this diff. ✅
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Detailed explanation of the changes
Normalize the
actionResultfield across seven pipeline filters so downstream rules, dashboards, and correlations receive a consistent, canonical vocabulary (denied/blocked/failed/success/accepted) instead of vendor-specific strings.Reasoning behind these changes
Rules, dashboards and correlations across UTMStack depend on
actionResultbeing one of a small, well-known set of values. Vendor logs use inconsistent casing and vocabulary (Denied,denied,Blocked,Failed,Failure,Succeeded,Success, etc.), which was leaking straight intoactionResultthrough severalrenamesteps. That leak broke downstream matching whenever a vendor changed casing or wording.This change:
renamesteps from overwritingactionResultwith non-canonical values, using a negativeregexMatchguard.denied,blocked,failed,success,accepted) viaaddsteps.The result is that correlation rules that filter by
actionResultbehave predictably regardless of the source vendor's spelling or casing.Issue
No related issue.