Skip to content

head: remove Default trait from HeadOptions - #12261

Open
cakebaker wants to merge 1 commit into
uutils:mainfrom
cakebaker:head_remove_default
Open

head: remove Default trait from HeadOptions#12261
cakebaker wants to merge 1 commit into
uutils:mainfrom
cakebaker:head_remove_default

Conversation

@cakebaker

Copy link
Copy Markdown
Contributor

I noticed that we use let mut options = Self::default(); in the constructor of HeadOptions, followed by setting all of its properties again. This PR simplifies the constructor and removes the Default trait from HeadOptions.

@cakebaker
cakebaker force-pushed the head_remove_default branch from 7ea912e to a715a8e Compare May 12, 2026 14:39
@github-actions

github-actions Bot commented May 12, 2026

Copy link
Copy Markdown

GNU testsuite comparison:

GNU test failed: tests/dd/misc. tests/dd/misc is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/df/over-mount-device. tests/df/over-mount-device is passing on 'main'. Maybe you have to rebase?
Skip an intermittent issue tests/tail/tail-n0f (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/cat/splice is no longer failing!
Congrats! The gnu test tests/cp/cp-a-selinux is no longer failing!
Congrats! The gnu test tests/cut/cut is no longer failing!
Congrats! The gnu test tests/cut/mb-non-utf8 is no longer failing!
Congrats! The gnu test tests/dd/partial-write is no longer failing!
Congrats! The gnu test tests/expand/mb is no longer failing!
Congrats! The gnu test tests/ls/stat-free-symlinks is no longer failing!
Congrats! The gnu test tests/misc/close-stdout is no longer failing!
Congrats! The gnu test tests/mktemp/write-error is no longer failing!
Congrats! The gnu test tests/mv/dir2dir is no longer failing!
Congrats! The gnu test tests/mv/mv-exchange is no longer failing!
Congrats! The gnu test tests/nl/multibyte is no longer failing!
Congrats! The gnu test tests/od/od-float is no longer failing!
Congrats! The gnu test tests/od/od-j is no longer failing!
Congrats! The gnu test tests/ptx/ptx-overrun is no longer failing!
Congrats! The gnu test tests/sort/sort-merge-fdlimit is no longer failing!
Congrats! The gnu test tests/unexpand/mb is no longer failing!
Note: The gnu test tests/dd/no-allocate is now being skipped but was previously passing.
Note: The gnu test tests/dd/fail-ftruncate-fstat was skipped on 'main' but is now failing.

@sylvestre
sylvestre force-pushed the head_remove_default branch from a715a8e to cea57ef Compare June 7, 2026 20:58
@cakebaker
cakebaker force-pushed the head_remove_default branch from cea57ef to 8b2f687 Compare July 21, 2026 08:57
@cakebaker

Copy link
Copy Markdown
Contributor Author

Changes since last push:

  • rebased and fixed conflict

@sylvestre

Copy link
Copy Markdown
Contributor

sorry, it needs to be rebased

@cakebaker
cakebaker force-pushed the head_remove_default branch from 8b2f687 to 4f67d2f Compare August 31, 2026 07:25
@cakebaker

cakebaker commented Aug 31, 2026

Copy link
Copy Markdown
Contributor Author

Changes since last push:

  • rebased and fixed a conflict
  • added Debug trait to SizeError as suggested by the error "the trait Debug is not implemented for SizeError"

@sylvestre
sylvestre enabled auto-merge (rebase) August 31, 2026 07:30
@cakebaker
cakebaker force-pushed the head_remove_default branch from 4f67d2f to 9642a89 Compare August 31, 2026 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants