Skip to content

coreutils: replace /proc/ by /dev/ - #12553

Merged
sylvestre merged 1 commit into
uutils:mainfrom
oech3:patch-1
Sep 2, 2026
Merged

coreutils: replace /proc/ by /dev/#12553
sylvestre merged 1 commit into
uutils:mainfrom
oech3:patch-1

Conversation

@oech3

@oech3 oech3 commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

Closes #12552

@github-actions

github-actions Bot commented Jun 1, 2026

Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/tail/inotify-dir-recreate (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/tail/tail-n0f (passes in this run but fails in the 'main' branch)
Note: The gnu test tests/cut/cut-huge-range is now being skipped but was previously passing.
Congrats! The gnu test tests/cut/bounded-memory is now passing!
Congrats! The gnu test tests/tail/pipe-f is now passing!

@sylvestre

Copy link
Copy Markdown
Contributor

please explain the why in the commit message

@oech3
oech3 marked this pull request as ready for review June 1, 2026 11:17
@oech3
oech3 force-pushed the patch-1 branch 5 times, most recently from 7da01bd to 91792a8 Compare June 9, 2026 03:09
@oech3

This comment was marked as outdated.

@codspeed-hq

codspeed-hq Bot commented Aug 25, 2026

Copy link
Copy Markdown

Merging this PR will degrade performance by 13.49%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

❌ 2 regressed benchmarks
✅ 355 untouched benchmarks
⏩ 50 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation false_consecutive_calls 294.7 ns 350.2 ns -15.86%
Simulation mv_directory 7.3 ms 8.2 ms -11.05%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing oech3:patch-1 (cfabc07) with main (adba541)2

Open in CodSpeed

Footnotes

  1. 50 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. No successful run was found on main (1c68c61) during the generation of this report, so adba541 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@oech3
oech3 force-pushed the patch-1 branch 2 times, most recently from 92360ed to 5cfbf32 Compare August 26, 2026 06:18
@sylvestre

Copy link
Copy Markdown
Contributor

selinux is sad :)
maybe we skip it here?

@oech3

This comment was marked as outdated.

@oech3
oech3 force-pushed the patch-1 branch 3 times, most recently from 85904e2 to 1ce1d7f Compare August 28, 2026 09:58
@sylvestre
sylvestre enabled auto-merge (rebase) August 28, 2026 10:00
auto-merge was automatically disabled August 30, 2026 09:35

Head branch was pushed to by a user without write access

@github-actions

github-actions Bot commented Aug 30, 2026

Copy link
Copy Markdown

Binary size comparison:

Individual binary size comparison VS main (threshold: >=5% AND >=4 KB).

Total size of compared binaries: 152.18 MB (+1004 KB, +0.65%)

Significant per-binary changes:
  comm     1.12 MB ->    2.33 MB  (+1.21 MB, +107.29%)

@oech3

oech3 commented Aug 30, 2026

Copy link
Copy Markdown
Contributor Author

Test on SELinux seems fixed now.

@oech3
oech3 force-pushed the patch-1 branch 2 times, most recently from 48a6a42 to 9ebdd28 Compare August 31, 2026 03:28
@oech3

oech3 commented Aug 31, 2026

Copy link
Copy Markdown
Contributor Author

@sylvestre ready to merge. (conflicted at cspell after CI passed).

AT_EXECFN is /dev/fd/N if binary was called by fexecve(3), not /proc/self/fd/N
@sylvestre
sylvestre enabled auto-merge (rebase) September 2, 2026 06:44
@sylvestre
sylvestre merged commit 49a1261 into uutils:main Sep 2, 2026
97 checks passed
@oech3
oech3 deleted the patch-1 branch September 2, 2026 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Multicall binary fails to dispatch when invoked via fexecve/execveat(..., AT_EMPTY_PATH) — derives util name from binary path instead of argv[0]

2 participants