Skip to content

sort: add complete no-thread WASI fallback - #13806

Draft
DePasqualeOrg wants to merge 6 commits into
uutils:mainfrom
DePasqualeOrg:codex/wasi-sort-no-threads
Draft

sort: add complete no-thread WASI fallback#13806
DePasqualeOrg wants to merge 6 commits into
uutils:mainfrom
DePasqualeOrg:codex/wasi-sort-no-threads

Conversation

@DePasqualeOrg

@DePasqualeOrg DePasqualeOrg commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

I'll try to split this into more manageable pieces. Please ignore until marked as ready for review.

@github-actions

github-actions Bot commented Aug 8, 2026

Copy link
Copy Markdown

GNU testsuite comparison:

Skipping an intermittent issue tests/date/date-locale-hour (passes in this run but fails in the 'main' branch)

@codspeed-hq

codspeed-hq Bot commented Aug 8, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 361 untouched benchmarks
⏩ 50 skipped benchmarks1


Comparing DePasqualeOrg:codex/wasi-sort-no-threads (5e2a8ab) with main (dfb953d)2

Open in CodSpeed

Footnotes

  1. 50 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. No successful run was found on main (48a2013) during the generation of this report, so dfb953d was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@eduardomourar eduardomourar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few suggestions.

Comment thread src/uu/sort/src/chunks.rs
Comment thread src/uu/sort/build.rs
Comment thread src/uu/sort/src/ext_sort/sync.rs
Comment thread src/uu/sort/src/ext_sort/sync.rs
Comment thread src/uu/sort/src/merge/mod.rs
Comment thread src/uu/sort/src/merge/sync.rs Outdated
Comment thread tests/by-util/test_sort.rs
@github-actions

Copy link
Copy Markdown

Binary size comparison:

Individual binary size comparison VS main (threshold: >=5% AND >=4 KB).

Total size of compared binaries: 148.94 MB (+324 KB, +0.21%)

Significant per-binary changes:
  install     1.24 MB ->    1.32 MB  (+80 KB, +6.29%)
  mkdir       1.09 MB ->    1.17 MB  (+80 KB, +7.14%)
  mkfifo      1.09 MB ->    1.16 MB  (+76 KB, +6.83%)
  mknod       1.09 MB ->    1.17 MB  (+76 KB, +6.79%)

@DePasqualeOrg
DePasqualeOrg force-pushed the codex/wasi-sort-no-threads branch from e08ef85 to 27896f1 Compare September 1, 2026 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants