expr: stop repeating the about line in --help - #14000
Conversation
Merging this PR will degrade performance by 0.07%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Simulation | cksum_crc |
41.4 ms | 43.1 ms | -3.86% |
| ⚡ | Simulation | numfmt_stream_to_si |
414.1 ms | 398.6 ms | +3.87% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing MsfPablo:fix/expr-help-duplicate-about (378a876) with main (b2a617e)2
Footnotes
-
320 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
-
No successful run was found on
main(e275cd5) during the generation of this report, so b2a617e was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩
|
GNU testsuite comparison: |
|
duplicated PR |
Fixes #13983.
expr-after-helpopened by restatingexpr-aboutverbatim, soexpr --helpprinted "Print the value of EXPRESSION to standard output" once as the clap about line and again a few lines down. Dropped the duplicated sentence from the after-help text and kept the part that is actually about the section below it.Applied to
en-US.ftlandfr-FR.ftl, which both carried the same duplication.GNU's
expr --helpreads "Print the value of EXPRESSION to standard output. A blank line below separates increasing precedence groups." as one paragraph, but it has no separate about line — clap prints ours already, so keeping only the second sentence gives the same result rather than diverging from GNU.cargo test --no-default-features --features expr --test tests test_expr: 132 passed.