Skip to content

od: remove unused properties from InputDecoder - #14023

Open
cakebaker wants to merge 2 commits into
uutils:mainfrom
cakebaker:od_remove_properties
Open

od: remove unused properties from InputDecoder#14023
cakebaker wants to merge 2 commits into
uutils:mainfrom
cakebaker:od_remove_properties

Conversation

@cakebaker

Copy link
Copy Markdown
Contributor

This PR is a follow-up to #14006 and removes the properties used_normal_length and used_peek_length from InputDecoder as they are unused.

Comment thread src/uu/od/src/input_decoder.rs Outdated
@@ -68,12 +61,11 @@ where
let (n, p) = self
.input
.peek_read(self.data.as_mut_slice(), self.reserved_peek_length)?;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does it make sense to use .map now?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, thanks! I changed it to use map and added @Devel08 as a co-author.

@cakebaker
cakebaker force-pushed the od_remove_properties branch from 4539298 to 0da745e Compare August 19, 2026 12:25
@codspeed-hq

codspeed-hq Bot commented Aug 19, 2026

Copy link
Copy Markdown

Merging this PR will degrade performance by 4.72%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

❌ 1 regressed benchmark
✅ 56 untouched benchmarks
⏩ 350 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation du_deep_tree[(100, 3)] 2.2 ms 2.4 ms -4.72%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing cakebaker:od_remove_properties (4539298) with main (f2987b5)2

Open in CodSpeed

Footnotes

  1. 350 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. No successful run was found on main (b2a617e) during the generation of this report, so f2987b5 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants