od: remove unused properties from InputDecoder - #14023
Conversation
| @@ -68,12 +61,11 @@ where | |||
| let (n, p) = self | |||
| .input | |||
| .peek_read(self.data.as_mut_slice(), self.reserved_peek_length)?; | |||
There was a problem hiding this comment.
does it make sense to use .map now?
There was a problem hiding this comment.
Good point, thanks! I changed it to use map and added @Devel08 as a co-author.
Co-authored-by: Devel <Denislav08@proton.me>
4539298 to
0da745e
Compare
Merging this PR will degrade performance by 4.72%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Simulation | du_deep_tree[(100, 3)] |
2.2 ms | 2.4 ms | -4.72% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing cakebaker:od_remove_properties (4539298) with main (f2987b5)2
Footnotes
-
350 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
-
No successful run was found on
main(b2a617e) during the generation of this report, so f2987b5 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩
This PR is a follow-up to #14006 and removes the properties
used_normal_lengthandused_peek_lengthfromInputDecoderas they are unused.