Skip to content

dd: simplify windows stdin in match guard #14347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cakebaker merged 1 commit into from
Sep 2, 2026
+8 −14
Merged

dd: simplify windows stdin in match guard #14347

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 8 additions & 14 deletions src/uu/dd/src/dd.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -366,20 +366,14 @@ impl<'a> Input<'a> {
#[cfg(windows)]
let mut src = {
let f = File::from(io::stdin().as_handle().try_clone_to_owned()?);
let is_file = if let Ok(metadata) = f.metadata() {
// this hack is needed as there is no other way on windows
// to differentiate between the case where `seek` works
// on a file handle or not. i.e. when the handle is no real
// file but a pipe, `seek` is still successful, but following
// `read`s are not affected by the seek.
metadata.creation_time() != 0
} else {
false
};
if is_file {
Source::File(f)
} else {
Source::Stdin(io::stdin())
// this hack is needed as there is no other way on windows
// to differentiate between the case where `seek` works
// on a file handle or not. i.e. when the handle is no real
// file but a pipe, `seek` is still successful, but following
// `read`s are not affected by the seek.
match f.metadata() {
Ok(metadata) if metadata.creation_time() != 0 => Source::File(f),
_ => Source::Stdin(io::stdin()),
}
};
#[cfg(all(not(unix), not(windows)))]
Expand Down
Loading