Skip to content

test: Honor PATHEXT on Windows - #14481

Merged
sylvestre merged 1 commit into
uutils:mainfrom
microsoft:windows/test-pathext
Sep 9, 2026
Merged

test: Honor PATHEXT on Windows#14481
sylvestre merged 1 commit into
uutils:mainfrom
microsoft:windows/test-pathext

Conversation

@lhecker

@lhecker lhecker commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

test was hardcoding the executable extensions on Windows.
This commit hooks it up to the PATHEXT env variable.

Co-authored-by: Alvaro Figueroa <alvaro.figueroa@microsoft.com>
Copilot AI lite review requested due to automatic review settings September 9, 2026 20:26

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No unresolved review comments remain, and all requested changes are covered.

Pull request overview

Updates Windows test -x behavior to honor the PATHEXT environment variable.

Changes:

  • Parse PATHEXT with a fallback to default executable extensions.
  • Add Windows coverage for custom and excluded extensions.
File summaries
File Description
tests/by-util/test_test.rs Adds Windows regression coverage for custom PATHEXT behavior.
src/uu/test/src/platform/windows.rs Uses PATHEXT for executable-extension matching.
Review details
  • Files reviewed: 2/2 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@sylvestre
sylvestre enabled auto-merge (squash) September 9, 2026 20:33
@sylvestre
sylvestre merged commit 4280637 into uutils:main Sep 9, 2026
98 of 99 checks passed
@github-actions

github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/cut/bounded-memory (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/tail/tail-n0f (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/date/resolution (passes in this run but fails in the 'main' branch)

@lhecker
lhecker deleted the windows/test-pathext branch September 9, 2026 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants