test: Honor PATHEXT on Windows - #14481
Merged
Merged
Conversation
Co-authored-by: Alvaro Figueroa <alvaro.figueroa@microsoft.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved review comments remain, and all requested changes are covered.
Pull request overview
Updates Windows test -x behavior to honor the PATHEXT environment variable.
Changes:
- Parse
PATHEXTwith a fallback to default executable extensions. - Add Windows coverage for custom and excluded extensions.
File summaries
| File | Description |
|---|---|
tests/by-util/test_test.rs |
Adds Windows regression coverage for custom PATHEXT behavior. |
src/uu/test/src/platform/windows.rs |
Uses PATHEXT for executable-extension matching. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
sylvestre
enabled auto-merge (squash)
September 9, 2026 20:33
|
GNU testsuite comparison: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
testwas hardcoding the executable extensions on Windows.This commit hooks it up to the
PATHEXTenv variable.