Skip to content

fix: add rust-version to Cargo.toml - #808

Open
xtqqczze wants to merge 8 commits into
uutils:mainfrom
xtqqczze:msrv
Open

fix: add rust-version to Cargo.toml#808
xtqqczze wants to merge 8 commits into
uutils:mainfrom
xtqqczze:msrv

Conversation

@xtqqczze

@xtqqczze xtqqczze commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Also update workflows to run on multiple os and rust-version.

verified with cargo hack check --workspace --all-targets --feature-powerset --rust-version

@codecov

codecov Bot commented Aug 4, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.15%. Comparing base (2a3eac9) to head (a8563b8).

Files with missing lines Patch % Lines
src/locate/mod.rs 33.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #808   +/-   ##
=======================================
  Coverage   92.15%   92.15%           
=======================================
  Files          35       35           
  Lines        7377     7377           
  Branches      383      383           
=======================================
  Hits         6798     6798           
  Misses        438      438           
  Partials      141      141           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown

Commit 80520b3 has test result changes:

bfs testsuite:

Test results comparison:
  Current:   TOTAL: 314 / PASSED: 267 / FAILED: 41 / SKIPPED: 6
  Reference: TOTAL: 313 / PASSED: 266 / FAILED: 41 / SKIPPED: 6

Changes from main branch:
  TOTAL: +1
  PASSED: +1
  FAILED: +0

@codspeed-hq

codspeed-hq Bot commented Aug 4, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 20 untouched benchmarks


Comparing xtqqczze:msrv (a8563b8) with main (2a3eac9)

Open in CodSpeed

@sylvestre

Copy link
Copy Markdown
Contributor

still draft ?

@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown

Commit f56295b has test result changes:

bfs testsuite:

Test results comparison:
  Current:   TOTAL: 313 / PASSED: 267 / FAILED: 40 / SKIPPED: 6
  Reference: TOTAL: 312 / PASSED: 266 / FAILED: 40 / SKIPPED: 6

Changes from main branch:
  TOTAL: +1
  PASSED: +1
  FAILED: +0

@xtqqczze
xtqqczze force-pushed the msrv branch 2 times, most recently from d28c810 to e8ad685 Compare August 7, 2026 14:54
@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown

Commit 4f9d519 has test result changes:

bfs testsuite:

Test results comparison:
  Current:   TOTAL: 314 / PASSED: 266 / FAILED: 42 / SKIPPED: 6
  Reference: TOTAL: 312 / PASSED: 266 / FAILED: 40 / SKIPPED: 6

Changes from main branch:
  TOTAL: +2
  PASSED: +0
  FAILED: +2

New test failures (2):
  - gnu/okdir_path_empty
  - gnu/okdir_path_relative

@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown

Commit d28c810 has test result changes:

bfs testsuite:

Test results comparison:
  Current:   TOTAL: 316 / PASSED: 267 / FAILED: 43 / SKIPPED: 6
  Reference: TOTAL: 312 / PASSED: 266 / FAILED: 40 / SKIPPED: 6

Changes from main branch:
  TOTAL: +4
  PASSED: +1
  FAILED: +3

New test failures (3):
  - gnu/files0_from_ok
  - gnu/okdir_path_empty
  - gnu/okdir_path_relative

@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown

Commit e8ad685 has test result changes:

bfs testsuite:

Test results comparison:
  Current:   TOTAL: 314 / PASSED: 267 / FAILED: 41 / SKIPPED: 6
  Reference: TOTAL: 312 / PASSED: 266 / FAILED: 40 / SKIPPED: 6

Changes from main branch:
  TOTAL: +2
  PASSED: +1
  FAILED: +1

New test failures (1):
  - gnu/okdir_path_empty

@xtqqczze
xtqqczze marked this pull request as ready for review August 7, 2026 15:08
@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown

Commit 1f49462 has test result changes:

bfs testsuite:

Test results comparison:
  Current:   TOTAL: 313 / PASSED: 267 / FAILED: 40 / SKIPPED: 6
  Reference: TOTAL: 312 / PASSED: 266 / FAILED: 40 / SKIPPED: 6

Changes from main branch:
  TOTAL: +1
  PASSED: +1
  FAILED: +0

@xtqqczze

xtqqczze commented Aug 7, 2026

Copy link
Copy Markdown
Contributor Author

@sylvestre ready

@github-actions

Copy link
Copy Markdown

Commit a8563b8 has test result changes:

bfs testsuite:

Test results comparison:
  Current:   TOTAL: 317 / PASSED: 274 / FAILED: 37 / SKIPPED: 6
  Reference: TOTAL: 313 / PASSED: 267 / FAILED: 40 / SKIPPED: 6

Changes from main branch:
  TOTAL: +4
  PASSED: +7
  FAILED: -3

Test improvements (3):
  + gnu/execdir_path_dot
  + gnu/execdir_path_empty
  + gnu/execdir_path_relative

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants